Skip to content

Commit 1e747f6

Browse files
committed
fix runtime requirements in tests
1 parent 4837a61 commit 1e747f6

File tree

2 files changed

+21
-11
lines changed

2 files changed

+21
-11
lines changed

tests/docstring_tests/DocTest.res

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,14 @@ let nodeVersion =
2121

2222
let ignoreRuntimeTests = [
2323
(
24-
// Ignore some tests not supported by node v18
25-
18,
24+
// Ignore some tests require Node.js v20+
25+
20,
26+
["Stdlib.Array.toReversed", "Stdlib.Array.toSorted"],
27+
),
28+
(
29+
// Ignore some tests require Node.js v22+
30+
22,
2631
[
27-
"Stdlib.Array.toReversed",
28-
"Stdlib.Array.toSorted",
2932
"Stdlib.Promise.withResolvers",
3033
"Stdlib.Set.union",
3134
"Stdlib.Set.isSupersetOf",
@@ -202,7 +205,7 @@ let main = async () => {
202205
let codeExamples = examples->Array.filterMap(example => {
203206
let ignoreExample =
204207
ignoreRuntimeTests->Array.some(
205-
((version, tests)) => nodeVersion === version && tests->Array.includes(example.id),
208+
((version, tests)) => nodeVersion < version && tests->Array.includes(example.id),
206209
)
207210

208211
if ignoreExample {

tests/docstring_tests/DocTest.res.mjs

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,17 @@ import * as RescriptTools_Docgen from "rescript/lib/es6/RescriptTools_Docgen.js"
2323

2424
let nodeVersion = Stdlib_Option.getExn(Stdlib_Int.fromString(Stdlib_Option.getExn(process.version.replace("v", "").split(".")[0], "Failed to find major version of Node"), undefined), "Failed to convert node version to Int");
2525

26-
let ignoreRuntimeTests = [[
27-
18,
26+
let ignoreRuntimeTests = [
27+
[
28+
20,
2829
[
2930
"Stdlib.Array.toReversed",
30-
"Stdlib.Array.toSorted",
31+
"Stdlib.Array.toSorted"
32+
]
33+
],
34+
[
35+
22,
36+
[
3137
"Stdlib.Promise.withResolvers",
3238
"Stdlib.Set.union",
3339
"Stdlib.Set.isSupersetOf",
@@ -37,7 +43,8 @@ let ignoreRuntimeTests = [[
3743
"Stdlib.Set.symmetricDifference",
3844
"Stdlib.Set.difference"
3945
]
40-
]];
46+
]
47+
];
4148

4249
function getOutput(buffer) {
4350
return buffer.map(e => e.toString()).join("");
@@ -60,7 +67,7 @@ async function extractDocFromFile(file) {
6067
RE_EXN_ID: "Assert_failure",
6168
_1: [
6269
"DocTest.res",
63-
58,
70+
61,
6471
9
6572
],
6673
Error: new Error()
@@ -237,7 +244,7 @@ async function main() {
237244
examples.sort((a, b) => Primitive_string.compare(a.name, b.name));
238245
let codeExamples = Stdlib_Array.filterMap(examples, example => {
239246
let ignoreExample = ignoreRuntimeTests.some(param => {
240-
if (nodeVersion === param[0]) {
247+
if (nodeVersion < param[0]) {
241248
return param[1].includes(example.id);
242249
} else {
243250
return false;

0 commit comments

Comments
 (0)