clean up the attribute after transformation

Author: mununki

compiler/syntax/src/jsx_v4.ml

@@ -1194,6 +1194,13 @@ let map_binding ~config ~empty_loc ~pstr_loc ~file_name ~rec_flag binding =
   else if Jsx_common.has_attr_on_binding Jsx_common.has_attr_with_props binding
   then
     let modified_binding = Jsx_common.remove_arity binding in
+    let modified_binding =
+      {
+        modified_binding with
+        pvb_attributes =
+          modified_binding.pvb_attributes |> List.filter other_attrs_pure;
+      }
+    in
     let fn_name = get_fn_name modified_binding.pvb_pat in
     let internal_fn_name = fn_name ^ "$Internal" in
     let full_module_name =

tests/syntax_tests/data/ppx/react/expected/sharedPropsWithProps.res.txt

@@ -5,7 +5,6 @@ let f = a => Js.Promise.resolve(a + a)
 module V4C1 = {
   type props = sharedProps
   let make = props => React.string(props.x ++ props.y)
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4C1" = props => make(props)
     \"SharedPropsWithProps$V4C1"
@@ -15,7 +14,6 @@ module V4C1 = {
 module V4C2 = {
   type props = sharedProps
   let make = (props: props) => React.string(props.x ++ props.y)
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4C2" = (props: props) => make(props)
     \"SharedPropsWithProps$V4C2"
@@ -25,7 +23,6 @@ module V4C2 = {
 module V4C3 = {
   type props<'a> = sharedProps<'a>
   let make = ({x, y}: props<_>) => React.string(x ++ y)
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4C3" = (props: props<_>) => make(props)
     \"SharedPropsWithProps$V4C3"
@@ -35,7 +32,6 @@ module V4C3 = {
 module V4C4 = {
   type props<'a> = sharedProps<string, 'a>
   let make = ({x, y}: props<_>) => React.string(x ++ y)
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4C4" = (props: props<_>) => make(props)
     \"SharedPropsWithProps$V4C4"
@@ -48,7 +44,6 @@ module V4C5 = {
     let a = await f(a)
     ReactDOM.createDOMElementVariadic("div", [{React.int(a)}])
   }
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4C5" = (props: props<_>) =>
       JsxPPXReactSupport.asyncComponent(make(props))
@@ -64,7 +59,6 @@ module V4C6 = {
     | #off => React.string("off")
     }
   }
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4C6" = (props: props<_>) =>
       JsxPPXReactSupport.asyncComponent(make(props))
@@ -77,7 +71,6 @@ module V4C6 = {
 module V4A1 = {
   type props = sharedProps
   let make = props => React.string(props.x ++ props.y)
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4A1" = props => make(props)
     \"SharedPropsWithProps$V4A1"
@@ -87,7 +80,6 @@ module V4A1 = {
 module V4A2 = {
   type props = sharedProps
   let make = (props: props) => React.string(props.x ++ props.y)
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4A2" = (props: props) => make(props)
     \"SharedPropsWithProps$V4A2"
@@ -97,7 +89,6 @@ module V4A2 = {
 module V4A3 = {
   type props<'a> = sharedProps<'a>
   let make = ({x, y}: props<_>) => React.string(x ++ y)
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4A3" = (props: props<_>) => make(props)
     \"SharedPropsWithProps$V4A3"
@@ -107,7 +98,6 @@ module V4A3 = {
 module V4A4 = {
   type props<'a> = sharedProps<string, 'a>
   let make = ({x, y}: props<_>) => React.string(x ++ y)
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4A4" = (props: props<_>) => make(props)
     \"SharedPropsWithProps$V4A4"
@@ -120,7 +110,6 @@ module V4A5 = {
     let a = await f(a)
     ReactDOM.jsx("div", {children: ?ReactDOM.someElement({React.int(a)})})
   }
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4A5" = (props: props<_>) =>
       JsxPPXReactSupport.asyncComponent(make(props))
@@ -136,7 +125,6 @@ module V4A6 = {
     | #off => React.string("off")
     }
   }
-  @react.componentWithProps
   let make = {
     let \"SharedPropsWithProps$V4A6" = (props: props<_>) =>
       JsxPPXReactSupport.asyncComponent(make(props))