drop primitive polyfill syntax

Author: cometkim

jscomp/common/bs_warnings.ml

@@ -1,5 +1,5 @@
 (* Copyright (C) 2015-2016 Bloomberg Finance L.P.
- * 
+ *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
@@ -17,14 +17,11 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU Lesser General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU Lesser General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
-let warn_missing_primitive loc txt =
-  Location.prerr_warning loc (Bs_unimplemented_primitive txt)
-
 let warn_literal_overflow loc =
   Location.prerr_warning loc Bs_integer_literal_overflow
 

jscomp/common/bs_warnings.mli

@@ -1,5 +1,5 @@
 (* Copyright (C) 2015-2016 Bloomberg Finance L.P.
- * 
+ *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
@@ -17,13 +17,11 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU Lesser General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU Lesser General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
-val warn_missing_primitive : Location.t -> string -> unit
-
 val warn_literal_overflow : Location.t -> unit
 
 val error_unescaped_delimiter : Location.t -> string -> unit

jscomp/core/js_exp_make.ml

@@ -17,7 +17,7 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU Lesser General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU Lesser General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
@@ -29,7 +29,7 @@ type t = J.expression
 (*
   [remove_pure_sub_exp x]
   Remove pure part of the expression (minor optimization)
-  and keep the non-pure part while preserve the semantics 
+  and keep the non-pure part while preserve the semantics
   (modulo return value)
   It will return None if  [x] is pure
  *)
@@ -86,8 +86,8 @@ let runtime_var_dot ?comment (x : string) (e1 : string) : J.expression =
 let ml_var_dot ?comment ?(dynamic_import = false) (id : Ident.t) e : J.expression =
   { expression_desc = Var (Qualified ({ id; kind = Ml; dynamic_import }, Some e)); comment }
 
-(** 
-   module as a value 
+(**
+   module as a value
    {[
      var http = require("http")
    ]}
@@ -182,7 +182,7 @@ let instanceof ?comment (e0 : t) (e1: t) : t =
 let is_array  (e0 : t) : t =
   let f = str "Array.isArray" ~delim:DNoQuotes in
   { expression_desc = Call (f, [e0], Js_call_info.ml_full_call); comment=None }
-  
+
 let new_ ?comment e0 args : t =
   { expression_desc = New (e0, Some args); comment }
 
@@ -455,7 +455,7 @@ let assign_by_exp (e : t) index value : t =
   | Array _
   (*
      Temporary block -- address not held
-     Optimize cases like this which is really 
+     Optimize cases like this which is really
      rare {[
                   (ref x) :=  3
                 ]}
@@ -474,7 +474,7 @@ let record_assign (e : t) (pos : int32) (name : string) (value : t) =
   | Array _
   (*
      Temporary block -- address not held
-     Optimize cases like this which is really 
+     Optimize cases like this which is really
      rare {[
                   (ref x) :=  3
                 ]}
@@ -492,7 +492,7 @@ let extension_assign (e : t) (pos : int32) name (value : t) =
   | Array _
   (*
            Temporary block -- address not held
-           Optimize cases like this which is really 
+           Optimize cases like this which is really
            rare {[
                   (ref x) :=  3
                 ]}
@@ -809,7 +809,7 @@ let tag_type = function
   | Ast_untagged_variants.String s -> str s ~delim:DStarJ
   | Int i -> small_int i
   | Float f -> float f
-  | BigInt i -> 
+  | BigInt i ->
     let sign, i = Bigint_utils.parse_bigint i in
     bigint sign i
   | Bool b -> bool b
@@ -841,7 +841,7 @@ let rec emit_check (check : t Ast_untagged_variants.DynamicChecks.t) = match che
   | IsInstanceOf (Array, x) -> is_array (emit_check x)
   | IsInstanceOf (instance, x) ->
     let instance_name = Ast_untagged_variants.Instance.to_string instance in
-    instanceof (emit_check x) (str instance_name ~delim:DNoQuotes) 
+    instanceof (emit_check x) (str instance_name ~delim:DNoQuotes)
   | Not x -> not (emit_check x)
   | Expr x -> x
 
@@ -1273,7 +1273,7 @@ let bigint_div ~checked ?comment (e0: t) (e1: t) =
     runtime_call Js_runtime_modules.bigint "div" [e0; e1]
   else
     bigint_op ?comment Div e0 e1
-    
+
 let bigint_mod ~checked ?comment (e0: t) (e1: t) =
   if checked then
     runtime_call Js_runtime_modules.bigint "mod_" [e0; e1]
@@ -1344,14 +1344,5 @@ let neq_null_undefined_boolean ?comment (a : t) (b : t) =
   | Null, Undefined _ | Undefined _, Null -> true_
   | _ -> { expression_desc = Bin (NotEqEq, a, b); comment }
 
-(** TODO: in the future add a flag
-    to set globalThis
-*)
-let resolve_and_apply (s : string) (args : t list) : t =
-  call ~info:Js_call_info.builtin_runtime_call
-    (runtime_call Js_runtime_modules.external_polyfill "resolve"
-       [ str (if s.[0] = '?' then String.sub s 1 (String.length s - 1) else s) ])
-    args
-
 let make_exception (s : string) =
   pure_runtime_call Js_runtime_modules.exceptions Literals.create [ str s ]

jscomp/core/js_exp_make.mli

@@ -1,5 +1,5 @@
 (* Copyright (C) 2015 - 2016 Bloomberg Finance L.P.
- * Copyright (C) 2017 - Hongbo Zhang, Authors of ReScript 
+ * Copyright (C) 2017 - Hongbo Zhang, Authors of ReScript
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
@@ -17,17 +17,17 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU Lesser General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU Lesser General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
 (** Creator utilities for the [J] module *)
 
 type t = J.expression
-(** check if a javascript ast is constant 
+(** check if a javascript ast is constant
 
-    The better signature might be 
+    The better signature might be
     {[
       J.expresssion -> Js_output.t
     ]}
@@ -146,7 +146,7 @@ val function_length : ?comment:string -> t -> t
 val string_append : ?comment:string -> t -> t -> t
 (**
    When in ES6 mode, we can use Symbol to guarantee its uniquess,
-   we can not tag [js] object, since it can be frozen 
+   we can not tag [js] object, since it can be frozen
 *)
 
 (* val var_dot : ?comment:string -> Ident.t -> string -> t *)
@@ -181,11 +181,11 @@ val poly_var_value_access : t -> t
 val extension_assign : t -> int32 -> string -> t -> t
 
 val assign_by_int : ?comment:string -> t -> int32 -> t -> t
-(** 
+(**
     [assign_by_int  e i v]
-    if the expression [e] is a temporay block 
+    if the expression [e] is a temporay block
     which has no side effect,
-    write to it does not really make sense, 
+    write to it does not really make sense,
     optimize it away *)
 
 val assign_by_exp : t -> t -> t -> t
@@ -332,9 +332,9 @@ val undefined : t
 
 val tag : ?comment:string -> ?name:string -> J.expression -> t
 
-(** Note that this is coupled with how we encode block, if we use the 
+(** Note that this is coupled with how we encode block, if we use the
     `Object.defineProperty(..)` since the array already hold the length,
-    this should be a nop 
+    this should be a nop
 *)
 
 val obj_length : ?comment:string -> J.expression -> t
@@ -363,6 +363,4 @@ val for_sure_js_null_undefined : J.expression -> bool
 
 val is_null_undefined : ?comment:string -> t -> t
 
-val resolve_and_apply : string -> t list -> t
-
 val make_exception : string -> t

jscomp/core/lam_compile_primitive.ml

@@ -1,5 +1,5 @@
 (* Copyright (C) 2015 - 2016 Bloomberg Finance L.P.
- * Copyright (C) 2017 - Hongbo Zhang, Authors of ReScript 
+ * Copyright (C) 2017 - Hongbo Zhang, Authors of ReScript
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
@@ -17,7 +17,7 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU Lesser General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU Lesser General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
@@ -400,7 +400,4 @@ let translate output_prefix loc (cxt : Lam_compile_context.t)
      Lfunction(Curried, [parm],
                Matching.inline_lazy_force (Lvar parm) Location.none)
      It is inlined, this should not appear here *) ->
-      (*we dont use [throw] here, since [throw] is an statement  *)
-      let s = Lam_print.primitive_to_string prim in
-      Bs_warnings.warn_missing_primitive loc s;
-      E.resolve_and_apply s args
+    assert false

jscomp/core/lam_dispatch_primitive.ml

@@ -1,5 +1,5 @@
 (* Copyright (C) 2015 - 2016 Bloomberg Finance L.P.
- * Copyright (C) 2017 - Hongbo Zhang, Authors of ReScript 
+ * Copyright (C) 2017 - Hongbo Zhang, Authors of ReScript
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
@@ -17,23 +17,23 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU Lesser General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU Lesser General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
 module E = Js_exp_make
 (* module S = Js_stmt_make *)
 
-(** 
+(**
    There are two things we need consider:
    1.  For some primitives we can replace caml-primitive with js primitives directly
    2.  For some standard library functions, we prefer to replace with javascript primitives
     For example [Pervasives["^"] -> ^]
     We can collect all mli files in OCaml and replace it with an efficient javascript runtime
 
-   TODO: return type to be expression is ugly, 
-   we should allow return block    
+   TODO: return type to be expression is ugly,
+   we should allow return block
 *)
 let translate loc (prim_name : string) (args : J.expression list) : J.expression
     =
@@ -263,13 +263,7 @@ let translate loc (prim_name : string) (args : J.expression list) : J.expression
   | "?await" -> (
       match args with
       | [e] -> {e with expression_desc = Await e}
-      | _ -> assert false
-  )
-  | _ ->
-      Bs_warnings.warn_missing_primitive loc prim_name;
-      E.resolve_and_apply prim_name args
-(*we dont use [throw] here, since [throw] is an statement
-  so we wrap in IIFE
-  TODO: we might provoide a hook for user to provide polyfill.
-  For example `Bs_global.xxx`
-*)
+      | _ -> assert false)
+  | missing_impl ->
+    let msg = Warnings.message (Bs_unimplemented_primitive missing_impl) in
+    Location.raise_errorf ~loc "%s" msg

jscomp/ext/js_runtime_modules.ml

@@ -65,8 +65,6 @@ let option = "Caml_option"
 
 let module_ = "Caml_module"
 
-let external_polyfill = "Caml_external_polyfill"
-
 let caml_js_exceptions = "Caml_js_exceptions"
 
 let caml_splice_call = "Caml_splice_call"

jscomp/ext/warnings.ml

@@ -485,30 +485,30 @@ let message = function
       ^ " : using an empty string as a shorthand to infer the external's name \
          from the value's name is dangerous when refactoring, and therefore \
          deprecated"
-  | Bs_unimplemented_primitive s -> "Unimplemented primitive used:" ^ s
+  | Bs_unimplemented_primitive s -> "Unimplemented primitive used: " ^ s
   | Bs_integer_literal_overflow ->
       "Integer literal exceeds the range of representable integers of type int"
   | Bs_uninterpreted_delimiters s -> "Uninterpreted delimiters " ^ s
   | Bs_toplevel_expression_unit help ->
-      Printf.sprintf "This%sis at the top level and is expected to return `unit`. But it's returning %s.\n\n  In ReScript, anything at the top level must evaluate to `unit`. You can fix this by assigning the expression to a value, or piping it into the `ignore` function.%s" 
-        (match help with 
-        | Some (_, FunctionCall) -> " function call " 
-        | _ -> " ") 
+      Printf.sprintf "This%sis at the top level and is expected to return `unit`. But it's returning %s.\n\n  In ReScript, anything at the top level must evaluate to `unit`. You can fix this by assigning the expression to a value, or piping it into the `ignore` function.%s"
+        (match help with
+        | Some (_, FunctionCall) -> " function call "
+        | _ -> " ")
 
-        (match help with 
-        | Some (return_type, _) -> Printf.sprintf "`%s`" return_type 
+        (match help with
+        | Some (return_type, _) -> Printf.sprintf "`%s`" return_type
         | None -> "something that is not `unit`")
 
-        (match help with 
+        (match help with
         | Some (_, help_typ) ->
-          let help_text = (match help_typ with 
-          | FunctionCall -> "yourFunctionCall()" 
+          let help_text = (match help_typ with
+          | FunctionCall -> "yourFunctionCall()"
           | Other -> "yourExpression") in
           Printf.sprintf "\n\n  Possible solutions:\n  - Assigning to a value that is then ignored: `let _ = %s`\n  - Piping into the built-in ignore function to ignore the result: `%s->ignore`" help_text help_text
-        | _ -> "") 
+        | _ -> "")
     | Bs_todo maybe_text -> (
-      match maybe_text with 
-      | None -> "Todo found." 
+      match maybe_text with
+      | None -> "Todo found."
       | Some todo -> "Todo found: " ^ todo
     ) ^ "\n\n  This code is not implemented yet and will crash at runtime. Make sure you implement this before running the code."