spread props errors

- first in order
- multiple use not allowed

Author: mununki

cli/reactjs_jsx_v4.ml

@@ -183,7 +183,16 @@ let recordFromProps ~loc ~removeKey callArguments =
     | (Nolabel, {pexp_loc}) :: _rest ->
       React_jsx_common.raiseError ~loc:pexp_loc
         "JSX: found non-labelled argument before the last position"
-    | prop :: rest -> removeLastPositionUnitAux rest (prop :: acc)
+    | ((Labelled txt, {pexp_loc}) as prop) :: rest
+    | ((Optional txt, {pexp_loc}) as prop) :: rest ->
+      if txt = "_spreadProps" then
+        match acc with
+        | [] -> removeLastPositionUnitAux rest (prop :: acc)
+        | _ ->
+          React_jsx_common.raiseError ~loc:pexp_loc
+            "JSX: spread props should be first in order than other props\n\
+            \            and multiple spread props are not allowed."
+      else removeLastPositionUnitAux rest (prop :: acc)
   in
   let props, propsToSpread =
     removeLastPositionUnitAux callArguments []

tests/ppx/react/expected/spreadProps.res.txt

@@ -1,8 +1,9 @@
 @@jsxConfig({version: 4, mode: "classic"})
-let c0 = React.createElement(A.make, {...p, x: "x"})
+// Error: spreadProps should be first in order than other props
+// let c0 = <A x="x" {...p} />
 
-// ignore second one
-let c0 = React.createElement(A.make, {...p0, x: "x"})
+// Error: multiple spreadProps not allowed
+// let c0 = <A x="x" {...p0} {...p1} />
 
 // only spread props
 let c1 = React.createElement(A.make, p)
@@ -11,10 +12,11 @@ let c1 = React.createElement(A.make, p)
 let c2 = React.createElement(A.make, {...p, x: "x"})
 
 @@jsxConfig({version: 4, mode: "automatic"})
-let c0 = React.jsx(A.make, {...p, x: "x"})
+// Error: spreadProps should be first in order than other props
+// let c0 = <A x="x" {...p} />
 
-// ignore second one
-let c0 = React.jsx(A.make, {...p0, x: "x"})
+// Error: multiple spreadProps not allowed
+// let c0 = <A x="x" {...p0} {...p1} />
 
 // only spread props
 let c1 = React.jsx(A.make, p)

tests/ppx/react/spreadProps.res

@@ -1,8 +1,9 @@
 @@jsxConfig({version:4, mode: "classic"})
-let c0 = <A x="x" {...p} />
+// Error: spreadProps should be first in order than other props
+// let c0 = <A x="x" {...p} />
 
-// ignore second one
-let c0 = <A x="x" {...p0} {...p1} />
+// Error: multiple spreadProps not allowed
+// let c0 = <A x="x" {...p0} {...p1} />
 
 // only spread props
 let c1 = <A {...p} />
@@ -11,10 +12,11 @@ let c1 = <A {...p} />
 let c2 = <A {...p} x="x" />
 
 @@jsxConfig({version:4, mode: "automatic"})
-let c0 = <A x="x" {...p} />
+// Error: spreadProps should be first in order than other props
+// let c0 = <A x="x" {...p} />
 
-// ignore second one
-let c0 = <A x="x" {...p0} {...p1} />
+// Error: multiple spreadProps not allowed
+// let c0 = <A x="x" {...p0} {...p1} />
 
 // only spread props
 let c1 = <A {...p} />