reduces rubocop warnings

Author: Peter Scholz

lib/grape-swagger/endpoint.rb

@@ -165,15 +165,13 @@ def response_object(route)
         response_model = @item
         response_model = expose_params_from_model(value[:model]) if value[:model]
 
+        next unless !response_model.start_with?('Swagger_doc') && ((@definitions[response_model] && value[:code].to_s.start_with?('2')) || value[:model])
+
         # TODO: proof that the definition exist, if model isn't specified
-        if !response_model.start_with?('Swagger_doc') &&
-           ((!!@definitions[response_model] && value[:code].to_s.start_with?('2')) ||
-           value[:model])
-          if route.route_is_array
-            memo[value[:code]][:schema] = { 'type' => 'array', 'items' => { '$ref' => "#/definitions/#{response_model}" } }
-          else
-            memo[value[:code]][:schema] = { '$ref' => "#/definitions/#{response_model}" }
-          end
+        if route.route_is_array
+          memo[value[:code]][:schema] = { 'type' => 'array', 'items' => { '$ref' => "#/definitions/#{response_model}" } }
+        else
+          memo[value[:code]][:schema] = { '$ref' => "#/definitions/#{response_model}" }
         end
       end
     end
@@ -190,7 +188,7 @@ def default_staus_codes
 
     def params_object(route)
       partition_params(route).map do |param, value|
-        parse_params(param, value, route.route_path, route.route_method)
+        parse_params(param, { required: false }.merge(value), route.route_path, route.route_method)
       end
     end
 
@@ -252,7 +250,7 @@ def expose_params_from_model(model)
       if GrapeEntity::VERSION =~ /0\.4\.\d/
         parameters = model.exposures ? model.exposures : model.documentation
       elsif GrapeEntity::VERSION =~ /0\.5\.\d/
-        parameters = model.root_exposures.each_with_object({}) do |value,memo|
+        parameters = model.root_exposures.each_with_object({}) do |value, memo|
           memo[value.attribute] = value.send(:options)
         end
       end
@@ -289,7 +287,7 @@ def parse_params(param, value, path, method)
       end
 
       description          = value.is_a?(Hash) ? value[:desc] || value[:description] : nil
-      required             = value.is_a?(Hash) ? !!value[:required] : false
+      required             = value.is_a?(Hash) ? value[:required] : false
       default_value        = value.is_a?(Hash) ? value[:default] : nil
       example              = value.is_a?(Hash) ? value[:example] : nil
       is_array             = value.is_a?(Hash) ? (value[:is_array] || false) : false

spec/swagger_v2/api_swagger_v2_format-content_type_spec.rb

@@ -0,0 +1,65 @@
+require 'spec_helper'
+
+describe 'format, content_type' do
+  include_context "the api entities"
+
+  before :all do
+    module TheApi
+      class ProducesApi < Grape::API
+        format :json
+
+        desc 'This uses formats for produces',
+          failure: [{code: 400, model: Entities::ApiError}],
+          formats: [:xml, :binary, "application/vdns"],
+          entity: Entities::UseResponse
+        get '/use_format' do
+          { "declared_params" => declared(params) }
+        end
+
+        desc 'This uses content_types for produces',
+          failure: [{code: 400, model: Entities::ApiError}],
+          content_types: [:xml, :binary, "application/vdns"],
+          entity: Entities::UseResponse
+        get '/use_content_type' do
+          { "declared_params" => declared(params) }
+        end
+
+        add_swagger_documentation
+      end
+    end
+  end
+
+  def app
+    TheApi::ProducesApi
+  end
+
+  subject do
+    get '/swagger_doc/use_format'
+    JSON.parse(last_response.body)
+  end
+
+  specify do
+    require 'pry'; binding.pry
+    expect(subject['paths']['/use_produces']['get']).to include('produces')
+    expect(subject['paths']['/use_produces']['get']['produces']).to eql([
+      'application/xml',
+      'application/octet-stream',
+      'application/vdns'
+      ])
+  end
+
+  subject do
+    get '/swagger_doc/use_content_type'
+    JSON.parse(last_response.body)
+  end
+
+  specify do
+    require 'pry'; binding.pry
+    expect(subject['paths']['/use_produces']['get']).to include('produces')
+    expect(subject['paths']['/use_produces']['get']['produces']).to eql([
+      'application/xml',
+      'application/octet-stream',
+      'application/vdns'
+      ])
+  end
+end