Skip to content

Commit 3df163a

Browse files
authored
Update rubocop and its todo (#2450)
* Update rubocop and its todo * Add CHANGELOG.md * Fix changelog
1 parent f73811a commit 3df163a

File tree

4 files changed

+24
-12
lines changed

4 files changed

+24
-12
lines changed

.rubocop.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,21 +57,18 @@ Metrics/ModuleLength:
5757
Metrics/PerceivedComplexity:
5858
Max: 15
5959

60-
RSpec/Capybara/FeatureMethods:
61-
Enabled: false
62-
6360
RSpec/ExampleLength:
6461
Max: 60
6562

6663
RSpec/NestedGroups:
6764
Max: 6
6865

69-
RSpec/FilePath:
70-
SpecSuffixOnly: true
71-
7266
RSpec/SpecFilePathFormat:
7367
Enabled: false
7468

69+
RSpec/SpecFilePathSuffix:
70+
Enabled: true
71+
7572
RSpec/MultipleExpectations:
7673
Enabled: false
7774

@@ -83,6 +80,3 @@ RSpec/MultipleMemoizedHelpers:
8380

8481
RSpec/ContextWording:
8582
Enabled: false
86-
87-
RSpecRails/HaveHttpStatus:
88-
Enabled: false

.rubocop_todo.yml

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2024-05-20 14:55:33 UTC using RuboCop version 1.63.2.
3+
# on 2024-06-15 15:12:21 UTC using RuboCop version 1.64.1.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
@@ -197,6 +197,7 @@ RSpec/RepeatedExampleGroupDescription:
197197

198198
# Offense count: 2
199199
# This cop supports safe autocorrection (--autocorrect).
200+
# Configuration parameters: AutoCorrect.
200201
RSpec/ScatteredSetup:
201202
Exclude:
202203
- 'spec/grape/util/inheritable_setting_spec.rb'
@@ -296,6 +297,22 @@ Style/Semicolon:
296297
Exclude:
297298
- 'spec/grape/api_spec.rb'
298299

300+
# Offense count: 2
301+
# This cop supports safe autocorrection (--autocorrect).
302+
Style/SuperArguments:
303+
Exclude:
304+
- 'lib/grape/api.rb'
305+
- 'spec/support/deprecated_warning_handlers.rb'
306+
307+
# Offense count: 2
308+
# This cop supports unsafe autocorrection (--autocorrect-all).
309+
# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments.
310+
# AllowedMethods: define_method
311+
Style/SymbolProc:
312+
Exclude:
313+
- 'benchmark/large_model.rb'
314+
- 'spec/grape/validations/params_scope_spec.rb'
315+
299316
# Offense count: 1
300317
# This cop supports unsafe autocorrection (--autocorrect-all).
301318
# Configuration parameters: EnforcedStyle.

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
#### Features
44

5+
* [#2450](https://github.com/ruby-grape/grape/pull/2450): Update RuboCop to 1.64.1 - [@ericproulx](https://github.com/ericproulx).
56
* Your contribution here.
67

78
#### Fixes

Gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ group :development, :test do
1010
gem 'builder', require: false
1111
gem 'bundler'
1212
gem 'rake'
13-
gem 'rubocop', '1.63.2', require: false
13+
gem 'rubocop', '1.64.1', require: false
1414
gem 'rubocop-performance', '1.21.0', require: false
15-
gem 'rubocop-rspec', '2.29.1', require: false
15+
gem 'rubocop-rspec', '3.0.1', require: false
1616
end
1717

1818
group :development do

0 commit comments

Comments
 (0)