Skip to content

Commit 848e97a

Browse files
authored
Remove builder as a dependency (#2445)
1 parent 7c3ff27 commit 848e97a

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
* [#2434](https://github.com/ruby-grape/grape/pull/2434): Implement nested `with` support in parameter dsl - [@numbata](https://github.com/numbata).
3131
* [#2438](https://github.com/ruby-grape/grape/pull/2438): Fix some Rack::Lint - [@ericproulx](https://github.com/ericproulx).
3232
* [#2437](https://github.com/ruby-grape/grape/pull/2437): Add length validator - [@dhruvCW](https://github.com/dhruvCW).
33+
* [#2445](https://github.com/ruby-grape/grape/pull/2445): Remove builder as a dependency - [@ericproulx](https://github.com/ericproulx).
3334
* Your contribution here.
3435

3536
#### Fixes

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ source('https://rubygems.org')
77
gemspec
88

99
group :development, :test do
10+
gem 'builder', require: false
1011
gem 'bundler'
1112
gem 'rake'
1213
gem 'rubocop', '1.63.2', require: false

UPGRADING.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@ Upgrading Grape
33

44
### Upgrading to >= 2.1.0
55

6+
#### Optional Builder
7+
8+
The `builder` gem dependency has been made optional as it's only used when generating XML. If your code does, add `builder` to your `Gemfile`.
9+
10+
See [#2445](https://github.com/ruby-grape/grape/pull/2445) for more information.
11+
612
#### Deep Merging of Parameter Attributes
713

814
Grape now uses `deep_merge` to combine parameter attributes within the `with` method. Previously, attributes defined at the parameter level would override those defined at the group level.

grape.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ Gem::Specification.new do |s|
2121
}
2222

2323
s.add_runtime_dependency 'activesupport', '>= 6'
24-
s.add_runtime_dependency 'builder'
2524
s.add_runtime_dependency 'dry-types', '>= 1.1'
2625
s.add_runtime_dependency 'mustermann-grape', '~> 1.1.0'
2726
s.add_runtime_dependency 'rack', '>= 2'

0 commit comments

Comments
 (0)