Skip to content

Commit f48cde3

Browse files
authored
Merge pull request #2248 from dblock/rspec-3.11.0
Upgraded to rspec 3.11.0.
2 parents 71cf33a + 76fa2ff commit f48cde3

15 files changed

+20
-19
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
* [#2233](https://github.com/ruby-grape/grape/pull/2233): A setting for disabling documentation to internal APIs - [@dnesteryuk](https://github.com/dnesteryuk).
66
* [#2235](https://github.com/ruby-grape/grape/pull/2235): Add Ruby 3.1 to CI - [@petergoldstein](https://github.com/petergoldstein).
7+
* [#2248](https://github.com/ruby-grape/grape/pull/2248): Upgraded to rspec 3.11.0 - [@dblock](https://github.com/dblock).
78
* Your contribution here.
89

910
#### Fixes

Gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/multi_json.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/multi_xml.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/rack1.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/rack2.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/rack2_2.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/rack_edge.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/rails_5.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/rails_6.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/rails_6_1.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/rails_7.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

gemfiles/rails_edge.gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group :test do
3333
gem 'mime-types'
3434
gem 'rack-jsonp', require: 'rack/jsonp'
3535
gem 'rack-test', '~> 1.1.0'
36-
gem 'rspec', '~> 3.9.0'
36+
gem 'rspec', '~> 3.11.0'
3737
gem 'ruby-grape-danger', '~> 0.2.0', require: false
3838
gem 'test-prof', require: false
3939
end

spec/grape/dsl/request_response_spec.rb

+6-6
Original file line numberDiff line numberDiff line change
@@ -160,34 +160,34 @@ def self.imbue(key, value)
160160

161161
describe 'list of exceptions is passed' do
162162
it 'sets hash of exceptions as rescue handlers' do
163-
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, StandardError => nil)
163+
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, { StandardError => nil })
164164
expect(subject).to receive(:namespace_stackable).with(:rescue_options, {})
165165
subject.rescue_from StandardError
166166
end
167167

168168
it 'rescues only base handlers if rescue_subclasses: false option is passed' do
169-
expect(subject).to receive(:namespace_reverse_stackable).with(:base_only_rescue_handlers, StandardError => nil)
170-
expect(subject).to receive(:namespace_stackable).with(:rescue_options, rescue_subclasses: false)
169+
expect(subject).to receive(:namespace_reverse_stackable).with(:base_only_rescue_handlers, { StandardError => nil })
170+
expect(subject).to receive(:namespace_stackable).with(:rescue_options, { rescue_subclasses: false })
171171
subject.rescue_from StandardError, rescue_subclasses: false
172172
end
173173

174174
it 'sets given proc as rescue handler for each key in hash' do
175175
rescue_handler_proc = proc {}
176-
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, StandardError => rescue_handler_proc)
176+
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, { StandardError => rescue_handler_proc })
177177
expect(subject).to receive(:namespace_stackable).with(:rescue_options, {})
178178
subject.rescue_from StandardError, rescue_handler_proc
179179
end
180180

181181
it 'sets given block as rescue handler for each key in hash' do
182182
rescue_handler_proc = proc {}
183-
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, StandardError => rescue_handler_proc)
183+
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, { StandardError => rescue_handler_proc })
184184
expect(subject).to receive(:namespace_stackable).with(:rescue_options, {})
185185
subject.rescue_from StandardError, &rescue_handler_proc
186186
end
187187

188188
it 'sets a rescue handler declared through :with option for each key in hash' do
189189
with_block = -> { 'hello' }
190-
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, StandardError => an_instance_of(Proc))
190+
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, { StandardError => an_instance_of(Proc) })
191191
expect(subject).to receive(:namespace_stackable).with(:rescue_options, {})
192192
subject.rescue_from StandardError, with: with_block
193193
end

spec/grape/dsl/routing_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class Dummy
1919
it 'sets a version for route' do
2020
version = 'v1'
2121
expect(subject).to receive(:namespace_inheritable).with(:version, [version])
22-
expect(subject).to receive(:namespace_inheritable).with(:version_options, using: :path)
22+
expect(subject).to receive(:namespace_inheritable).with(:version_options, { using: :path })
2323
expect(subject.version(version)).to eq(version)
2424
end
2525
end

0 commit comments

Comments
 (0)