Skip to content

[Peers] Tech Debt: disconnect_socket vs. socket_disconnected naming confusion #712

Open
@julianknutsen

Description

@julianknutsen

As a user of LDK, I want a clearer naming convention between PeerManager::socket_disconnected and SocketDescriptor::disconnect_socket so that it is easier to differentiate between the two.

Definition of Done:

  • Get 1 more +1 for on_socket_disconnected or the next best thing
  • Do the rename

Tech Discussion:
@ariard suggested on_socket_disconnected here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions