Simplify const reference check

weirane · Veykril · weirane · commit 4a0821f332a2 · 2022-05-17T11:43:53.000-07:00
Co-authored-by: Lukas Wirth &lt;lukastw97@gmail.com&gt;
diff --git a/crates/ide-assists/src/handlers/convert_let_else_to_match.rs b/crates/ide-assists/src/handlers/convert_let_else_to_match.rs
@@ -17,7 +17,7 @@ fn binders_in_pat(
             let ident = p.name()?;
             let ismut = p.ref_token().is_none() && p.mut_token().is_some();
             // check for const reference
-            if !(p.is_simple_ident() && sem.resolve_bind_pat_to_const(p).is_some()) {
+            if sem.resolve_bind_pat_to_const(p).is_none() {
                 acc.push((ident, ismut));
             }
             if let Some(inner) = p.pat() {

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ fn binders_in_pat(`
`17`	`17`	`let ident = p.name()?;`
`18`	`18`	`let ismut = p.ref_token().is_none() && p.mut_token().is_some();`
`19`	`19`	`// check for const reference`
`20`		`- if !(p.is_simple_ident() && sem.resolve_bind_pat_to_const(p).is_some()) {`
	`20`	`+ if sem.resolve_bind_pat_to_const(p).is_none() {`
`21`	`21`	`acc.push((ident, ismut));`
`22`	`22`	`}`
`23`	`23`	`if let Some(inner) = p.pat() {`