Skip to content

Deploy by using travis pages provider #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 30, 2019
Merged

Deploy by using travis pages provider #193

merged 4 commits into from
Mar 30, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Mar 29, 2019

tesuji
tesuji commented Mar 29, 2019
View reviewed changes
@KodrAus
Copy link
Contributor

KodrAus commented Mar 29, 2019

Thanks @lzutao!

This looks good to me, but I haven't used the GitHub Pages deployment feature of Travis before so am not totally sure how it works.

As a start, do you mind setting the target_branch to something like gh_pages_test so we can make sure we're getting the right stuff out without potentially breaking the current docs? Then I'll merge this one in and if it all looks good we'll change it to point to gh_pages.

KodrAus
KodrAus reviewed Mar 29, 2019
View reviewed changes
@tesuji
Copy link
Contributor Author

tesuji commented Mar 30, 2019

The only things that I'm worry is incorrect token type. In that case, the deploy stage would be failed
so the old pages would be kept.

@tesuji tesuji closed this Mar 30, 2019
@tesuji tesuji reopened this Mar 30, 2019
KodrAus
KodrAus approved these changes Mar 30, 2019
View reviewed changes
Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lzutao! This looks good to me.

@KodrAus KodrAus merged commit 3e790cd into rust-lang:master Mar 30, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Mar 30, 2019

This works as expected 👍

@KodrAus KodrAus mentioned this pull request Mar 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodrAus KodrAus KodrAus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesuji @KodrAus