Skip to content

Commit 6642373

Browse files
committed
Small nits
1 parent c29cc2c commit 6642373

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

src/cargo/core/dependency.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -318,14 +318,8 @@ impl Dependency {
318318
}
319319

320320
/// Sets the version requirement for this dependency.
321-
pub fn set_version_req(&mut self, req: VersionReq) -> &mut Dependency {
322-
Rc::make_mut(&mut self.inner).req = OptVersionReq::Req(req);
323-
self
324-
}
325-
326-
/// Sets the version requirement as any for this dependency.
327-
pub fn set_version_req_as_any(&mut self) -> &mut Dependency {
328-
Rc::make_mut(&mut self.inner).req = OptVersionReq::Any;
321+
pub fn set_version_req(&mut self, req: OptVersionReq) -> &mut Dependency {
322+
Rc::make_mut(&mut self.inner).req = req;
329323
self
330324
}
331325

src/cargo/core/resolver/errors.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use std::task::Poll;
44
use crate::core::{Dependency, PackageId, Registry, Summary};
55
use crate::sources::source::QueryKind;
66
use crate::util::edit_distance::edit_distance;
7-
use crate::util::{Config, VersionExt};
7+
use crate::util::{Config, OptVersionReq, VersionExt};
88
use anyhow::Error;
99

1010
use super::context::Context;
@@ -225,7 +225,7 @@ pub(super) fn activation_error(
225225
// was meant. So we re-query the registry with `dep="*"` so we can
226226
// list a few versions that were actually found.
227227
let mut new_dep = dep.clone();
228-
new_dep.set_version_req_as_any();
228+
new_dep.set_version_req(OptVersionReq::Any);
229229

230230
let mut candidates = loop {
231231
match registry.query_vec(&new_dep, QueryKind::Exact) {

src/cargo/util/toml/mod.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use cargo_platform::Platform;
1010
use cargo_util::paths;
1111
use itertools::Itertools;
1212
use lazycell::LazyCell;
13-
use semver::{self, VersionReq};
13+
use semver;
1414
use serde::de::{self, IntoDeserializer as _, Unexpected};
1515
use serde::ser;
1616
use serde::{Deserialize, Serialize};
@@ -38,6 +38,8 @@ pub mod embedded;
3838
mod targets;
3939
use self::targets::targets;
4040

41+
use super::OptVersionReq;
42+
4143
/// Loads a `Cargo.toml` from a file on disk.
4244
///
4345
/// This could result in a real or virtual manifest being returned.
@@ -2656,7 +2658,7 @@ impl TomlManifest {
26562658
replacement.unused_keys(),
26572659
&mut cx.warnings,
26582660
);
2659-
dep.set_version_req(VersionReq::exact(version))
2661+
dep.set_version_req(OptVersionReq::exact(version))
26602662
.lock_version(version);
26612663
replace.push((spec, dep));
26622664
}

0 commit comments

Comments
 (0)