Skip to content

Commit 025cf16

Browse files
committed
Auto merge of #3137 - rust-lang:renovate/eslint-plugin-ember-10.x, r=Turbo87
Update dependency eslint-plugin-ember to v10.1.0 [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-ember](https://togithub.com/ember-cli/eslint-plugin-ember) | [`10.0.2` -> `10.1.0`](https://renovatebot.com/diffs/npm/eslint-plugin-ember/10.0.2/10.1.0) | [![age](https://badges.renovateapi.com/packages/npm/eslint-plugin-ember/10.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/eslint-plugin-ember/10.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/eslint-plugin-ember/10.1.0/compatibility-slim/10.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/eslint-plugin-ember/10.1.0/confidence-slim/10.0.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ember-cli/eslint-plugin-ember</summary> ### [`v10.1.0`](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/CHANGELOG.md#v1010-2020-12-28) [Compare Source](https://togithub.com/ember-cli/eslint-plugin-ember/compare/v10.0.2...v10.1.0) ##### 🚀 Enhancement - [#&#8203;1056](https://togithub.com/ember-cli/eslint-plugin-ember/pull/1056) Add new rule [no-current-route-name](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-current-route-name.md) ([`@&#8203;Turbo87](https://togithub.com/Turbo87))` - [#&#8203;1055](https://togithub.com/ember-cli/eslint-plugin-ember/pull/1055) Add new rule [require-fetch-import](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/require-fetch-import.md) ([`@&#8203;Turbo87](https://togithub.com/Turbo87))` ##### 🐛 Bug Fix - [#&#8203;1054](https://togithub.com/ember-cli/eslint-plugin-ember/pull/1054) Handle commas inside quotes in selectors in [require-valid-css-selector-in-test-helpers](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/require-valid-css-selector-in-test-helpers.md) rule ([`@&#8203;bmish](https://togithub.com/bmish))` - [#&#8203;1051](https://togithub.com/ember-cli/eslint-plugin-ember/pull/1051) Fix path checks for Windows in [no-test-import-export](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-test-import-export.md) and [no-test-support-import](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-test-support-import.md) rules ([`@&#8203;dwickern](https://togithub.com/dwickern))` - [#&#8203;1038](https://togithub.com/ember-cli/eslint-plugin-ember/pull/1038) Improve detection of global window methods in [prefer-ember-test-helpers](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/prefer-ember-test-helpers.md) rule ([`@&#8203;bmish](https://togithub.com/bmish))` - [#&#8203;1043](https://togithub.com/ember-cli/eslint-plugin-ember/pull/1043) Fix false positive in [no-shadow-route-definition](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-shadow-route-definition.md) rule ([`@&#8203;raido](https://togithub.com/raido))` - [#&#8203;1040](https://togithub.com/ember-cli/eslint-plugin-ember/pull/1040) `willDestroy` should be considered a classic component lifecycle hook in [require-super-in-lifecycle-hooks](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/require-super-in-lifecycle-hooks.md) and [no-component-lifecycle-hooks](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-component-lifecycle-hooks.md) rules ([`@&#8203;bmish](https://togithub.com/bmish))` - [#&#8203;1036](https://togithub.com/ember-cli/eslint-plugin-ember/pull/1036) Catch `willDestroy` Glimmer component hook in [require-super-in-lifecycle-hooks](https://togithub.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/require-super-in-lifecycle-hooks.md) rule ([`@&#8203;bmish](https://togithub.com/bmish))` ##### 🏠 Internal - [#&#8203;1052](https://togithub.com/ember-cli/eslint-plugin-ember/pull/1052) Add Windows to CI testing matrix ([`@&#8203;dwickern](https://togithub.com/dwickern))` ##### Committers: 4 - Bryan Mishkin ([`@&#8203;bmish](https://togithub.com/bmish))` - Derek Wickern ([`@&#8203;dwickern](https://togithub.com/dwickern))` - Raido Kuli ([`@&#8203;raido](https://togithub.com/raido))` - Tobias Bieniek ([`@&#8203;Turbo87](https://togithub.com/Turbo87))` </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).
2 parents 6779805 + f8b9cb4 commit 025cf16

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

app/components/download-graph.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ export default class DownloadGraph extends Component {
3232
}
3333

3434
willDestroy() {
35+
super.willDestroy(...arguments);
3536
window.removeEventListener('resize', this.resizeHandler);
3637
}
3738

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@
107107
"ember-window-mock": "0.7.1",
108108
"eslint": "7.16.0",
109109
"eslint-config-prettier": "7.1.0",
110-
"eslint-plugin-ember": "10.0.2",
110+
"eslint-plugin-ember": "10.1.0",
111111
"eslint-plugin-ember-concurrency": "0.2.1",
112112
"eslint-plugin-import-helpers": "1.1.0",
113113
"eslint-plugin-prettier": "3.3.0",

yarn.lock

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7366,14 +7366,15 @@ [email protected]:
73667366
resolved "https://registry.yarnpkg.com/eslint-plugin-ember-concurrency/-/eslint-plugin-ember-concurrency-0.2.1.tgz#9836226a4e2287259250ed57d4f9315d254fbc8f"
73677367
integrity sha512-Gan1/Cc0w7w7e+BmIOPIzjiVQumhRguGJDnk49JUWfMVFwECOPvAJ++BOesEj3ogIpQDLeLNMYHN9gtjXmtM8Q==
73687368

7369-
eslint-plugin-ember@10.0.2:
7370-
version "10.0.2"
7371-
resolved "https://registry.yarnpkg.com/eslint-plugin-ember/-/eslint-plugin-ember-10.0.2.tgz#5e81c6baf75ca62fce424c0a422e494cee2d4421"
7372-
integrity sha512-GKZhLsnvODkAhORlsnT24D451Kl47ykMoqYKktZJR2Q3+3kklcU0Bj8xkqKJj/HVhsBH80FD74yTiYZKavSqFg==
7369+
eslint-plugin-ember@10.1.0:
7370+
version "10.1.0"
7371+
resolved "https://registry.yarnpkg.com/eslint-plugin-ember/-/eslint-plugin-ember-10.1.0.tgz#e7ca20cb1255c93732cd0d233d3f4fcb1bd591ea"
7372+
integrity sha512-NP2bwa1zCuHk0HWk2zAG3COybGqk3okIxtQYRkW8YBJymDJGdLsJ+yD1B1ZJO9J3w3vPPZRF+wulkQsv7ppagQ==
73737373
dependencies:
73747374
"@ember-data/rfc395-data" "^0.0.4"
73757375
css-tree "^1.0.0-alpha.39"
73767376
ember-rfc176-data "^0.3.15"
7377+
eslint-utils "^2.1.0"
73777378
lodash.kebabcase "^4.1.1"
73787379
snake-case "^3.0.3"
73797380

0 commit comments

Comments
 (0)