Skip to content

Commit 182290c

Browse files
committed
Auto merge of #3246 - plaets:issue-3245, r=Turbo87
Sort versions in download graph using semverSort Fixes #3245
2 parents bf22455 + 469afed commit 182290c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

app/components/download-graph.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import Component from '@glimmer/component';
55

66
import subDays from 'date-fns/subDays';
77
import window from 'ember-window-mock';
8+
import semverSort from 'semver/functions/sort';
89

910
// Colors by http://colorbrewer2.org/#type=diverging&scheme=RdBu&n=10
1011
const COLORS = ['#67001f', '#b2182b', '#d6604d', '#f4a582', '#92c5de', '#4393c3', '#2166ac', '#053061'];
@@ -102,7 +103,7 @@ export default class DownloadGraph extends Component {
102103
}
103104
});
104105

105-
let versionsList = [...versions].sort();
106+
let versionsList = semverSort([...versions]);
106107
if (extra.length !== 0) {
107108
versionsList.unshift('Other');
108109
}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@
4444
"date-fns": "2.17.0",
4545
"fastboot-app-server": "3.0.0",
4646
"morgan": "1.10.0",
47-
"pretty-bytes": "5.5.0"
47+
"pretty-bytes": "5.5.0",
48+
"semver": "7.3.4"
4849
},
4950
"devDependencies": {
5051
"@ember/optional-features": "2.0.0",
@@ -121,7 +122,6 @@
121122
"qunit": "2.13.0",
122123
"qunit-console-grouper": "0.3.0",
123124
"qunit-dom": "1.6.0",
124-
"semver": "7.3.4",
125125
"timekeeper": "2.2.0"
126126
},
127127
"engines": {

0 commit comments

Comments
 (0)