Skip to content

Commit 21cb664

Browse files
committed
Auto merge of #3132 - Turbo87:author, r=hi-rustin
Remove "Authors" section from crate details page see rust-lang/rfcs#3052 😉 r? `@pietroalbini`
2 parents db2c059 + 81a1758 commit 21cb664

File tree

3 files changed

+0
-23
lines changed

3 files changed

+0
-23
lines changed

app/components/crate-sidebar.hbs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,6 @@
103103
{{/each}}
104104
</ul>
105105
</div>
106-
107-
<div>
108-
<h3>Authors</h3>
109-
<ul>
110-
{{#each @version.authorNames as |author|}}
111-
<li>{{ format-email author }}</li>
112-
{{/each}}
113-
</ul>
114-
</div>
115106
</div>
116107

117108
<div local-class='bottom'>

app/models/version.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export default class Version extends Model {
2525
@belongsTo('crate', { async: false }) crate;
2626

2727
@belongsTo('user', { async: false }) published_by;
28-
@hasMany('users', { async: true }) authors;
2928
@hasMany('dependency', { async: true }) dependencies;
3029
@hasMany('version-download', { async: true }) version_downloads;
3130

@@ -97,15 +96,6 @@ export default class Version extends Model {
9796
.map(name => ({ name, isDefault: defaultFeatures.includes(name), dependencies: features[name] }));
9897
}
9998

100-
@alias('loadAuthorsTask.last.value') authorNames;
101-
102-
@(task(function* () {
103-
// trigger the async relationship to load the content
104-
let authors = yield this.authors;
105-
return authors.meta.names;
106-
}).keepLatest())
107-
loadAuthorsTask;
108-
10999
@alias('loadDepsTask.last.value.normal') normalDependencies;
110100
@alias('loadDepsTask.last.value.build') buildDependencies;
111101
@alias('loadDepsTask.last.value.dev') devDependencies;

app/routes/crate/version.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ export default class VersionRoute extends Route {
3232
setupController(controller, model) {
3333
super.setupController(...arguments);
3434

35-
if (!model.version.authorNames) {
36-
model.version.loadAuthorsTask.perform();
37-
}
38-
3935
controller.loadReadmeTask.perform().catch(() => {
4036
// ignored
4137
});

0 commit comments

Comments
 (0)