CrateSidebar: Remove "Manage Owners" link

This is now much more prominently displayed as a dedicated tab

Author: Turbo87

app/components/crate-sidebar.hbs

@@ -79,14 +79,6 @@
     <div>
       <h3>Owners</h3>
 
-      {{#if this.isOwner}}
-        <p>
-          <LinkTo @route="crate.owners" @model={{@crate}} data-test-manage-owners-link>
-            Manage owners
-          </LinkTo>
-        </p>
-      {{/if}}
-
       <ul local-class='owners' data-test-owners>
         {{#each @crate.owner_team as |team|}}
           <li>

app/components/crate-sidebar.js

@@ -1,18 +1,10 @@
 import { computed } from '@ember/object';
 import { gt, readOnly } from '@ember/object/computed';
-import { inject as service } from '@ember/service';
 import Component from '@glimmer/component';
 
 const NUM_VERSIONS = 5;
 
 export default class DownloadGraph extends Component {
-  @service session;
-
-  @computed('args.crate.owner_user', 'session.currentUser.id')
-  get isOwner() {
-    return this.args.crate.owner_user.findBy('id', this.session.currentUser?.id);
-  }
-
   @readOnly('args.crate.versions') sortedVersions;
 
   @computed('sortedVersions')

tests/acceptance/crate-test.js

@@ -211,7 +211,7 @@ module('Acceptance | crate page', function (hooks) {
 
     await visit('/crates/nanomsg');
 
-    assert.dom('[data-test-manage-owners-link]').doesNotExist();
+    assert.dom('[data-test-settings-tab]').doesNotExist();
   });
 
   test('navigating to the owners page when not an owner', async function (assert) {
@@ -222,7 +222,7 @@ module('Acceptance | crate page', function (hooks) {
 
     await visit('/crates/nanomsg');
 
-    assert.dom('[data-test-manage-owners-link]').doesNotExist();
+    assert.dom('[data-test-settings-tab]').doesNotExist();
   });
 
   test('navigating to the owners page', async function (assert) {
@@ -232,7 +232,7 @@ module('Acceptance | crate page', function (hooks) {
     this.authenticateAs(user);
 
     await visit('/crates/nanomsg');
-    await click('[data-test-manage-owners-link]');
+    await click('[data-test-settings-tab] a');
 
     assert.equal(currentURL(), '/crates/nanomsg/owners');
   });