Implement /crates/:crate_id/range/:range route

... that redirects the user to the highest version that satisfies the specified semver range

Author: Turbo87

app/router.js

@@ -15,6 +15,7 @@ Router.map(function () {
     this.route('dependencies');
     this.route('version', { path: '/:version_num' });
     this.route('version-dependencies', { path: '/:version_num/dependencies' });
+    this.route('range', { path: '/range/:range' });
 
     this.route('reverse-dependencies', { path: 'reverse_dependencies' });
 

app/routes/crate/range.js

@@ -0,0 +1,26 @@
+import Route from '@ember/routing/route';
+import { inject as service } from '@ember/service';
+
+import maxSatisfying from 'semver/ranges/max-satisfying';
+
+export default class VersionRoute extends Route {
+  @service notifications;
+  @service router;
+
+  async model({ range }) {
+    let crate = this.modelFor('crate');
+
+    let versions = await crate.get('versions');
+    let allVersionNums = versions.map(it => it.num);
+    let unyankedVersionNums = versions.filter(it => !it.yanked).map(it => it.num);
+
+    // find a version that matches the specified range
+    let versionNum = maxSatisfying(unyankedVersionNums, range) ?? maxSatisfying(allVersionNums, range);
+    if (!versionNum) {
+      this.notifications.error(`No matching version of crate '${crate.name}' found for: ${range}`);
+      this.replaceWith('crate.index');
+    }
+
+    this.router.replaceWith('crate.version', versionNum);
+  }
+}

tests/routes/crate/range-test.js

@@ -0,0 +1,78 @@
+import { currentURL, visit } from '@ember/test-helpers';
+import { module, test } from 'qunit';
+
+import { setupApplicationTest } from 'cargo/tests/helpers';
+
+module('Route | crate.range', function (hooks) {
+  setupApplicationTest(hooks);
+
+  test('happy path', async function (assert) {
+    let crate = this.server.create('crate', { name: 'foo' });
+    this.server.create('version', { crate, num: '1.0.0' });
+    this.server.create('version', { crate, num: '1.1.0' });
+    this.server.create('version', { crate, num: '1.2.0' });
+    this.server.create('version', { crate, num: '1.2.3' });
+
+    await visit('/crates/foo/range/^1.1.0');
+    assert.equal(currentURL(), `/crates/foo/1.2.3`);
+    assert.dom('[data-test-crate-name]').hasText('foo');
+    assert.dom('[data-test-crate-version]').hasText('1.2.3');
+    assert.dom('[data-test-notification-message]').doesNotExist();
+  });
+
+  test('happy path with tilde range', async function (assert) {
+    let crate = this.server.create('crate', { name: 'foo' });
+    this.server.create('version', { crate, num: '1.0.0' });
+    this.server.create('version', { crate, num: '1.1.0' });
+    this.server.create('version', { crate, num: '1.1.1' });
+    this.server.create('version', { crate, num: '1.2.0' });
+
+    await visit('/crates/foo/range/~1.1.0');
+    assert.equal(currentURL(), `/crates/foo/1.1.1`);
+    assert.dom('[data-test-crate-name]').hasText('foo');
+    assert.dom('[data-test-crate-version]').hasText('1.1.1');
+    assert.dom('[data-test-notification-message]').doesNotExist();
+  });
+
+  test('ignores yanked versions if possible', async function (assert) {
+    let crate = this.server.create('crate', { name: 'foo' });
+    this.server.create('version', { crate, num: '1.0.0' });
+    this.server.create('version', { crate, num: '1.1.0' });
+    this.server.create('version', { crate, num: '1.1.1' });
+    this.server.create('version', { crate, num: '1.2.0', yanked: true });
+
+    await visit('/crates/foo/range/^1.0.0');
+    assert.equal(currentURL(), `/crates/foo/1.1.1`);
+    assert.dom('[data-test-crate-name]').hasText('foo');
+    assert.dom('[data-test-crate-version]').hasText('1.1.1');
+    assert.dom('[data-test-notification-message]').doesNotExist();
+  });
+
+  test('falls back to yanked version if necessary', async function (assert) {
+    let crate = this.server.create('crate', { name: 'foo' });
+    this.server.create('version', { crate, num: '1.0.0', yanked: true });
+    this.server.create('version', { crate, num: '1.1.0', yanked: true });
+    this.server.create('version', { crate, num: '1.1.1', yanked: true });
+    this.server.create('version', { crate, num: '2.0.0' });
+
+    await visit('/crates/foo/range/^1.0.0');
+    assert.equal(currentURL(), `/crates/foo/1.1.1`);
+    assert.dom('[data-test-crate-name]').hasText('foo');
+    assert.dom('[data-test-crate-version]').hasText('1.1.1');
+    assert.dom('[data-test-notification-message]').doesNotExist();
+  });
+
+  test('redirects to main crate page if no match found', async function (assert) {
+    let crate = this.server.create('crate', { name: 'foo' });
+    this.server.create('version', { crate, num: '1.0.0' });
+    this.server.create('version', { crate, num: '1.1.0' });
+    this.server.create('version', { crate, num: '1.1.1' });
+    this.server.create('version', { crate, num: '2.0.0' });
+
+    await visit('/crates/foo/range/^3');
+    assert.equal(currentURL(), `/crates/foo`);
+    assert.dom('[data-test-crate-name]').hasText('foo');
+    assert.dom('[data-test-crate-version]').hasText('2.0.0');
+    assert.dom('[data-test-notification-message="error"]').hasText("No matching version of crate 'foo' found for: ^3");
+  });
+});