Auto merge of #3182 - Turbo87:failure, r=pietroalbini

Remove obsolete `failure` dependency

The older `oauth2` release was the last thing that needed it but with our update to tokio 1.0 we also updated `oauth2`, so we can remove the `failure` dependency now. 🎉

r? `@pietroalbini`

Author: bors

Cargo.lock

@@ -54,7 +54,6 @@ dialoguer = "0.7.1"
 diesel = { version = "1.4.0", features = ["postgres", "serde_json", "chrono", "r2d2"] }
 diesel_full_text_search = "1.0.0"
 dotenv = "0.15"
-failure = "0.1.1"
 flate2 = "1.0"
 futures-channel = { version = "0.3.1", default-features = false }
 futures-util = "0.3"

Cargo.toml

@@ -2,7 +2,6 @@ use crate::controllers::frontend_prelude::*;
 
 use crate::github;
 use conduit_cookie::RequestSession;
-use failure::Fail;
 use oauth2::reqwest::http_client;
 use oauth2::{AuthorizationCode, Scope, TokenResponse};
 
@@ -99,7 +98,6 @@ pub fn authorize(req: &mut dyn RequestExt) -> EndpointResult {
         .github
         .exchange_code(code)
         .request(http_client)
-        .map_err(|e| e.compat())
         .chain_error(|| server_error("Error obtaining token"))?;
     let token = token.access_token();