Skip to content

Commit cef9d9a

Browse files
jshasyphar
authored andcommitted
Replace links to /releases/<owner> with crates.io
1 parent b985946 commit cef9d9a

File tree

4 files changed

+4
-54
lines changed

4 files changed

+4
-54
lines changed

src/web/releases.rs

-44
Original file line numberDiff line numberDiff line change
@@ -1403,50 +1403,6 @@ mod tests {
14031403
});
14041404
}
14051405

1406-
#[test]
1407-
fn owners_page() {
1408-
wrapper(|env| {
1409-
let web = env.frontend();
1410-
env.fake_release()
1411-
.name("some_random_crate")
1412-
.add_owner(CrateOwner {
1413-
login: "foobar".into(),
1414-
avatar: "https://example.org/foobar".into(),
1415-
name: "Foo Bar".into(),
1416-
email: "[email protected]".into(),
1417-
})
1418-
.create()?;
1419-
// Request an owner without @ sign.
1420-
assert_success("/releases/foobar", web)?;
1421-
// Request an owner with @ sign.
1422-
assert_success("/releases/@foobar", web)
1423-
})
1424-
}
1425-
1426-
#[test]
1427-
fn owners_pagination() {
1428-
wrapper(|env| {
1429-
let web = env.frontend();
1430-
for i in 0..RELEASES_IN_RELEASES {
1431-
env.fake_release()
1432-
.name(&format!("some_random_crate_{}", i))
1433-
.add_owner(CrateOwner {
1434-
login: "foobar".into(),
1435-
avatar: "https://example.org/foobar".into(),
1436-
name: "Foo Bar".into(),
1437-
email: "[email protected]".into(),
1438-
})
1439-
.create()?;
1440-
}
1441-
let page = kuchiki::parse_html().one(web.get("/releases/@foobar").send()?.text()?);
1442-
let button = page.select_first("a[href='/releases/@foobar/2']");
1443-
1444-
assert!(button.is_ok());
1445-
1446-
Ok(())
1447-
})
1448-
}
1449-
14501406
#[test]
14511407
fn home_page_links() {
14521408
wrapper(|env| {

templates/crate/details.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@
127127
<li class="pure-menu-heading">Owners</li>
128128
<li class="pure-menu-item">
129129
{%- for owner in details.owners -%}
130-
<a href="/releases/{{ owner[0] }}">
130+
<a href="https://crates.io/users/{{ owner[0] }}">
131131
<img src="{{ owner[1] }}" alt="{{ owner[0] }}" class="owner">
132132
</a>
133133
{%- endfor -%}

templates/releases/releases.html

+2-8
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,14 @@
5858

5959
<div class="pagination">
6060
{% block pagination %}
61-
{%- if release_type == 'owner' -%}
62-
{%- set page_link = "/releases/" ~ owner -%}
63-
{%- else -%}
64-
{%- set page_link = "/releases/" ~ release_type -%}
65-
{%- endif -%}
66-
6761
{%- if show_previous_page -%}
68-
<a class="pure-button pure-button-normal" href="{{ page_link | safe }}/{{ page_number - 1 }}{{ query | default(value='') }}">
62+
<a class="pure-button pure-button-normal" href="/releases/{{ release_type }}/{{ page_number - 1 }}{{ query | default(value='') }}">
6963
{{ "arrow-left" | fas }} Previous Page
7064
</a>
7165
{%- endif -%}
7266

7367
{%- if show_next_page -%}
74-
<a class="pure-button pure-button-normal" href="{{ page_link | safe }}/{{ page_number + 1 }}{{ query | default(value='') }}">
68+
<a class="pure-button pure-button-normal" href="/releases/{{ release_type }}/{{ page_number + 1 }}{{ query | default(value='') }}">
7569
Next Page {{ "arrow-right" | fas }}
7670
</a>
7771
{%- endif -%}

templates/rustdoc/topbar.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797

9898
{%- for owner in krate.owners -%}
9999
<li class="pure-menu-item">
100-
<a href="/releases/{{ owner[0] }}" class="pure-menu-link">
100+
<a href="https://crates.io/users/{{ owner[0] }}" class="pure-menu-link">
101101
{{ "user" | fas(fw=true) }} {{ owner[0] }}
102102
</a>
103103
</li>

0 commit comments

Comments
 (0)