Skip to content

Redirect /releases/user to crates.io #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Oct 13, 2022

Fixes #1872

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 13, 2022
@Nemo157 Nemo157 linked an issue Oct 13, 2022 that may be closed by this pull request
@Nemo157
Copy link
Member

Nemo157 commented Oct 13, 2022

It would be good to also update the templates to go directly to crates.io (then maybe we can remove the redirect in the future if it turns out the only user was crawlers finding it through other pages).

(Technically it's possible to have non-crates.io owners if using an alternative registry which supports the owners API, but I don't think that's a usecase we need to consider right now).

Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! Less code is better :)

Apart from a test I'm fine with this.

@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 13, 2022
@jsha jsha force-pushed the redirect-releases branch from dd4c5e0 to 7440a47 Compare October 14, 2022 06:02
@syphar syphar merged commit ca1f1dd into rust-lang:master Oct 14, 2022
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 14, 2022
@jsha jsha deleted the redirect-releases branch October 15, 2022 04:18
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants