Skip to content

Support git_commit_create_cb in RebaseOptions #850

Open
@CouleeApps

Description

@CouleeApps

Currently, the RebaseOptions structure is missing support for commit_create_cb from the git_rebase_options C structure, which is used to facilitate things like commit signing in rebase operations. It would be useful to have safe access to this field to allow for custom commit signing abilities for rebase operations. It looks like the git_rebase_options structure has a payload field at the end which can be used for maintaining state across the FFI boundary, so implementation is hopefully not too complicated.

Followup discussion: signing_cb is also unimplemented, but marked as deprecated in the libgit2 C api. As such, it does not seem necessary to me to implement support for it. commit_create_cb seems to supersede its functionality.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions