Skip to content
This repository was archived by the owner on Mar 14, 2023. It is now read-only.

Commit 18a9cb8

Browse files
Add unit test
1 parent c2f0b97 commit 18a9cb8

File tree

2 files changed

+27
-0
lines changed

2 files changed

+27
-0
lines changed

highfive/tests/fakes.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ def get_repo_configs():
4848
"groups": {"all": []},
4949
"dirs": {},
5050
},
51+
'teams': {
52+
"groups": {"all": [], "a": ["@pnkfelix"], "b/c": ["@nrc"]}
53+
}
5154
}
5255

5356

highfive/tests/test_newpr.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1275,6 +1275,30 @@ def test_with_files(self):
12751275
assert set(["pnkfelix", "nrc", "aturon"]) == chosen_reviewers
12761276
assert set([()]) == mentions
12771277

1278+
def test_with_team_ping(self):
1279+
"""Test choosing a reviewer when passed a team ping"""
1280+
handler = HighfiveHandlerMock(
1281+
Payload({}), repo_config=self.fakes['config']['teams']
1282+
).handler
1283+
1284+
found_cases = (
1285+
("r? @foo/a", "pnkfelix"),
1286+
("r? @b/c", "nrc"),
1287+
)
1288+
1289+
not_found_cases = (
1290+
"r? @/a",
1291+
"r? @a/b",
1292+
)
1293+
1294+
for (msg, reviewer) in found_cases:
1295+
assert handler.find_reviewer(msg, None) == reviewer, \
1296+
"expected '%s' from '%s'" % (reviewer, msg)
1297+
1298+
for msg in not_found_cases:
1299+
assert handler.find_reviewer(msg, None) is None, \
1300+
"expected '%s' to have no reviewer extracted" % msg
1301+
12781302

12791303
class TestRun(TestNewPR):
12801304
@pytest.fixture(autouse=True)

0 commit comments

Comments
 (0)