Skip to content

Commit 02d27a4

Browse files
committed
Auto merge of #3127 - JohnTitor:rm-semver-check, r=JohnTitor
Drop semver check job on CI This hasn't run for a while and the crate no longer works unless a whole rewriting happens (due to the save analysis removal). We sometimes allow breaking changes if an item doesn't work in all the use cases (i.e. we can imply there's no real user). For these reasons, I think it's fine to remove these jobs.
2 parents f536356 + 204aee3 commit 02d27a4

File tree

3 files changed

+1
-102
lines changed

3 files changed

+1
-102
lines changed

.github/workflows/bors.yml

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -317,32 +317,6 @@ jobs:
317317
run: LIBC_CI=1 TOOLCHAIN=${{ matrix.toolchain }} WIN_TARGET=${{ matrix.target }} sh ./ci/build.sh
318318
shell: bash
319319

320-
semver_linux:
321-
if: ${{ false }} # This is currently broken
322-
name: Semver Linux
323-
runs-on: ubuntu-22.04
324-
continue-on-error: true
325-
steps:
326-
- uses: actions/checkout@v3
327-
- name: Setup Rust toolchain
328-
# Should update the semverver revision in semver.sh if we touch nightly ver.
329-
run: TOOLCHAIN=nightly-2022-05-23 sh ./ci/install-rust.sh
330-
- name: Check breaking changes
331-
run: sh ci/semver.sh linux
332-
333-
semver_macos:
334-
if: ${{ false }} # This is currently broken
335-
name: Semver macOS
336-
runs-on: macos-12
337-
continue-on-error: true
338-
steps:
339-
- uses: actions/checkout@v3
340-
- name: Setup Rust toolchain
341-
# Pin nightly version to make semverver compilable.
342-
run: TOOLCHAIN=nightly-2022-05-23 sh ./ci/install-rust.sh
343-
- name: Check breaking changes
344-
run: sh ci/semver.sh macos
345-
346320
docs:
347321
permissions:
348322
actions: write # to cancel workflows (rust-lang/simpleinfra/github-actions/cancel-outdated-builds)

ci/semver.sh

Lines changed: 0 additions & 75 deletions
This file was deleted.

libc-test/semver/linux-gnu.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,4 +669,4 @@ strftime
669669
strptime
670670
dirname
671671
posix_basename
672-
gnu_basename
672+
gnu_basename

0 commit comments

Comments
 (0)