Skip to content

Commit 03b410a

Browse files
committed
Update a couple of comments
1 parent d6c991e commit 03b410a

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

libc-test/build.rs

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2566,7 +2566,8 @@ fn test_emscripten(target: &str) {
25662566
// FIXME: The size has been changed when upgraded to musl 1.2.2
25672567
"pthread_mutex_t" => true,
25682568

2569-
// FIXME: The size has been changed
2569+
// FIXME: Lowered from 16 to 8 bytes in
2570+
// llvm/llvm-project@d1a96e9
25702571
"max_align_t" => true,
25712572

25722573
// FIXME: The size has been changed due to time64
@@ -2579,20 +2580,13 @@ fn test_emscripten(target: &str) {
25792580

25802581
cfg.skip_fn(move |name| {
25812582
match name {
2582-
// FIXME: https://github.com/rust-lang/libc/issues/1272
2583-
"execv" | "execve" | "execvp" | "execvpe" | "fexecve" => true,
2583+
// Emscripten does not support fork/exec/wait or any kind of multi-process support
2584+
// https://github.com/emscripten-core/emscripten/blob/3.1.30/tools/system_libs.py#L973
2585+
"execv" | "execve" | "execvp" | "execvpe" | "fexecve" | "wait4" => true,
25842586

2585-
// FIXME: Investigate why CI is missing it.
2587+
// FIXME: Remove after emscripten-core/emscripten#18492 is released (> 3.1.30).
25862588
"clearenv" => true,
25872589

2588-
// FIXME: Somehow the ctest cannot find it on emscripten:
2589-
// = note: error: undefined symbol: wait4 (referenced by top-level compiled C/C++ code)
2590-
// warning: Link with `-sLLD_REPORT_UNDEFINED` to get more information on undefined symbols
2591-
// warning: To disable errors for undefined symbols use `-sERROR_ON_UNDEFINED_SYMBOLS=0`
2592-
// warning: _wait4 may need to be added to EXPORTED_FUNCTIONS if it arrives from a system library
2593-
// Error: Aborting compilation due to previous errors
2594-
"wait4" => true,
2595-
25962590
_ => false,
25972591
}
25982592
});

libc-test/semver/TODO-unix.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
# These symbols are missing for the targets:
1+
# These symbols are no-op or missing on these targets:
22
# * asmjs-unknown-emscripten
3+
# * wasm32-unknown-emscripten
34
getpwuid_r
45
pthread_atfork
56
pthread_sigmask

0 commit comments

Comments
 (0)