Move static function to inline function - this fixes a conceivable

echristo · echristo · commit 40ac4221c30f · 2020-01-16T16:12:46.000-08:00
ODR violation and a clang-tidy warning about an unused function
in a number of translation units.
diff --git a/llvm/include/llvm/Analysis/ScalarEvolutionExpressions.h b/llvm/include/llvm/Analysis/ScalarEvolutionExpressions.h
@@ -64,7 +64,7 @@ class Type;
     }
   };
 
-  static unsigned short computeExpressionSize(ArrayRef<const SCEV *> Args) {
+  inline unsigned short computeExpressionSize(ArrayRef<const SCEV *> Args) {
     APInt Size(16, 1);
     for (auto *Arg : Args)
       Size = Size.uadd_sat(APInt(16, Arg->getExpressionSize()));

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ class Type;`
`64`	`64`	`}`
`65`	`65`	`};`
`66`	`66`
`67`		`- static unsigned short computeExpressionSize(ArrayRef<const SCEV *> Args) {`
	`67`	`+ inline unsigned short computeExpressionSize(ArrayRef<const SCEV *> Args) {`
`68`	`68`	`APInt Size(16, 1);`
`69`	`69`	`for (auto *Arg : Args)`
`70`	`70`	`Size = Size.uadd_sat(APInt(16, Arg->getExpressionSize()));`