Skip to content
This repository was archived by the owner on Feb 5, 2019. It is now read-only.

Commit 0701e5d

Browse files
committed
[FastISel][X86] Use XOR to materialize the "0" value.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@215594 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent f245d9a commit 0701e5d

File tree

5 files changed

+34
-11
lines changed

5 files changed

+34
-11
lines changed

lib/Target/X86/X86FastISel.cpp

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3107,6 +3107,29 @@ unsigned X86FastISel::X86MaterializeInt(const ConstantInt *CI, MVT VT) {
31073107
return 0;
31083108

31093109
uint64_t Imm = CI->getZExtValue();
3110+
if (Imm == 0) {
3111+
unsigned SrcReg = FastEmitInst_(X86::MOV32r0, &X86::GR32RegClass);
3112+
switch (VT.SimpleTy) {
3113+
default: llvm_unreachable("Unexpected value type");
3114+
case MVT::i1:
3115+
case MVT::i8:
3116+
return FastEmitInst_extractsubreg(MVT::i8, SrcReg, /*Kill=*/true,
3117+
X86::sub_8bit);
3118+
case MVT::i16:
3119+
return FastEmitInst_extractsubreg(MVT::i16, SrcReg, /*Kill=*/true,
3120+
X86::sub_16bit);
3121+
case MVT::i32:
3122+
return SrcReg;
3123+
case MVT::i64: {
3124+
unsigned ResultReg = createResultReg(&X86::GR64RegClass);
3125+
BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc,
3126+
TII.get(TargetOpcode::SUBREG_TO_REG), ResultReg)
3127+
.addImm(0).addReg(SrcReg).addImm(X86::sub_32bit);
3128+
return ResultReg;
3129+
}
3130+
}
3131+
}
3132+
31103133
unsigned Opc = 0;
31113134
switch (VT.SimpleTy) {
31123135
default: llvm_unreachable("Unexpected value type");

test/CodeGen/X86/fast-isel-cmp-branch3.ll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ bb1:
351351
define i32 @icmp_eq(i32 %x) {
352352
; CHECK-LABEL: icmp_eq
353353
; CHECK-NOT: cmpl
354-
; CHECK: movl $0, %eax
354+
; CHECK: xorl %eax, %eax
355355
%1 = icmp eq i32 %x, %x
356356
br i1 %1, label %bb1, label %bb2
357357
bb2:
@@ -387,7 +387,7 @@ bb1:
387387
define i32 @icmp_uge(i32 %x) {
388388
; CHECK-LABEL: icmp_uge
389389
; CHECK-NOT: cmpl
390-
; CHECK: movl $0, %eax
390+
; CHECK: xorl %eax, %eax
391391
%1 = icmp uge i32 %x, %x
392392
br i1 %1, label %bb1, label %bb2
393393
bb2:
@@ -411,7 +411,7 @@ bb1:
411411
define i32 @icmp_ule(i32 %x) {
412412
; CHECK-LABEL: icmp_ule
413413
; CHECK-NOT: cmpl
414-
; CHECK: movl $0, %eax
414+
; CHECK: xorl %eax, %eax
415415
%1 = icmp ule i32 %x, %x
416416
br i1 %1, label %bb1, label %bb2
417417
bb2:
@@ -435,7 +435,7 @@ bb1:
435435
define i32 @icmp_sge(i32 %x) {
436436
; CHECK-LABEL: icmp_sge
437437
; CHECK-NOT: cmpl
438-
; CHECK: movl $0, %eax
438+
; CHECK: xorl %eax, %eax
439439
%1 = icmp sge i32 %x, %x
440440
br i1 %1, label %bb1, label %bb2
441441
bb2:
@@ -459,7 +459,7 @@ bb1:
459459
define i32 @icmp_sle(i32 %x) {
460460
; CHECK-LABEL: icmp_sle
461461
; CHECK-NOT: cmpl
462-
; CHECK: movl $0, %eax
462+
; CHECK: xorl %eax, %eax
463463
%1 = icmp sle i32 %x, %x
464464
br i1 %1, label %bb1, label %bb2
465465
bb2:

test/CodeGen/X86/fast-isel-mem.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ entry:
3636
store i32 (...)** getelementptr ([4 x i32 (...)*]* @LotsStuff, i32 0, i32 2), i32 (...)*** null, align 4
3737
ret void
3838
; CHECK: _t:
39-
; CHECK: movl $0, %eax
39+
; CHECK: xorl %eax, %eax
4040
; CHECK: movl L_LotsStuff$non_lazy_ptr, %ecx
4141

4242
; ATOM: _t:
4343
; ATOM: movl L_LotsStuff$non_lazy_ptr, %e{{..}}
44-
; ATOM: movl $0, %e{{..}}
44+
; ATOM: xorl %e{{..}}, %e{{..}}
4545

4646
}

test/CodeGen/X86/fast-isel-x86-64.ll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ if.end: ; preds = %if.then, %entry
144144
; CHECK-LABEL: test12:
145145
; CHECK: testb $1,
146146
; CHECK-NEXT: je L
147-
; CHECK-NEXT: movl $0, %edi
147+
; CHECK-NEXT: xorl %edi, %edi
148148
; CHECK-NEXT: callq
149149
}
150150

@@ -154,7 +154,7 @@ define void @test13() nounwind {
154154
call void @test13f(i1 0)
155155
ret void
156156
; CHECK-LABEL: test13:
157-
; CHECK: movl $0, %edi
157+
; CHECK: xorl %edi, %edi
158158
; CHECK-NEXT: callq
159159
}
160160

@@ -278,7 +278,7 @@ entry:
278278
call void @foo22(i32 3)
279279
ret void
280280
; CHECK-LABEL: test22:
281-
; CHECK: movl $0, %edi
281+
; CHECK: xorl %edi, %edi
282282
; CHECK: callq _foo22
283283
; CHECK: movl $1, %edi
284284
; CHECK: callq _foo22

test/DebugInfo/X86/fission-ranges.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
; if they've changed due to a bugfix, change in register allocation, etc.
2626

2727
; CHECK: [[A]]: Beginning address index: 2
28-
; CHECK-NEXT: Length: 199
28+
; CHECK-NEXT: Length: 190
2929
; CHECK-NEXT: Location description: 11 00
3030
; CHECK-NEXT: {{^$}}
3131
; CHECK-NEXT: Beginning address index: 3

0 commit comments

Comments
 (0)