Switch to file ids

Author: matklad

crates/libanalysis/src/lib.rs

@@ -37,7 +37,6 @@ pub type Result<T> = ::std::result::Result<T, ::failure::Error>;
 const INDEXING_THRESHOLD: usize = 128;
 
 pub struct WorldState {
-    next_file_id: u32,
     data: Arc<WorldData>
 }
 
@@ -47,12 +46,11 @@ pub struct World {
 }
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)]
-pub struct FileId(u32);
 
 impl WorldState {
     pub fn new() -> WorldState {
         WorldState {
-            next_file_id: 0,
             data: Arc::new(WorldData::default())
         }
     }
@@ -61,12 +59,6 @@ impl WorldState {
         World { data: self.data.clone() }
     }
 
-    pub fn new_file_id(&mut self) -> FileId {
-        let id = FileId(self.next_file_id);
-        self.next_file_id += 1;
-        id
-    }
-
     pub fn change_file(&mut self, file_id: FileId, text: Option<String>) {
         self.change_files(::std::iter::once((file_id, text)));
     }

crates/server/Cargo.toml

@@ -16,6 +16,7 @@ log = "0.4.3"
 url_serde = "0.2.0"
 languageserver-types = "0.49.0"
 walkdir = "2.2.0"
+im = { version = "11.0.1", features = ["arc"] }
 text_unit = { version = "0.1.2", features = ["serde"] }
 
 libsyntax2 = { path = "../libsyntax2" }

crates/server/src/conv.rs

@@ -1,10 +1,12 @@
-use std::path::Path;
-
-use languageserver_types::{Range, SymbolKind, Position, TextEdit, Location, Url};
+};
 use libeditor::{LineIndex, LineCol, Edit, AtomEdit};
 use libsyntax2::{SyntaxKind, TextUnit, TextRange};
+use libanalysis::FileId;
 
-use Result;
 
 pub trait Conv {
     type Output;
@@ -115,21 +117,65 @@ impl ConvWith for AtomEdit {
     }
 }
 
-impl<'a> TryConvWith for (&'a Path, TextRange) {
-    type Ctx = LineIndex;
-    type Output = Location;
+    fn try_conv_with(self, path_map: &PathMap) -> Result<FileId> {
+        let path = self.to_file_path()
+            .map_err(|()| format_err!("invalid uri: {}", self))?;
+        path_map.get_id(&path).ok_or_else(|| format_err!("unknown file: {}", path.display()))
+    }
+}
+
+impl TryConvWith for FileId {
+    type Ctx = PathMap;
+    type Output = Url;
+    fn try_conv_with(self, path_map: &PathMap) -> Result<Url> {
+        let path = path_map.get_path(self);
+        let url = Url::from_file_path(path)
+            .map_err(|()| format_err!("can't convert path to url: {}", path.display()))?;
+        Ok(url)
+    }
+}
+
+impl<'a> TryConvWith for &'a TextDocumentItem {
+    type Ctx = PathMap;
+    type Output = FileId;
+    fn try_conv_with(self, path_map: &PathMap) -> Result<FileId> {
+        self.uri.try_conv_with(path_map)
+    }
+}
 
-    fn try_conv_with(self, line_index: &LineIndex) -> Result<Location> {
+    type Ctx = PathMap;
+    type Output = FileId;
+    fn try_conv_with(self, path_map: &PathMap) -> Result<FileId> {
+        self.uri.try_conv_with(path_map)
+    }
+}
+
+impl<'a> TryConvWith for &'a TextDocumentIdentifier {
+    type Ctx = PathMap;
+    type Output = FileId;
+    fn try_conv_with(self, path_map: &PathMap) -> Result<FileId> {
+        self.uri.try_conv_with(path_map)
+    }
+}
+
+pub fn to_location(
+    file_id: FileId,
+    range: TextRange,
+    path_map: &PathMap,
+    line_index: &LineIndex,
+) -> Result<Location> {
+        let url = file_id.try_conv_with(path_map)?;
         let loc = Location::new(
-            Url::from_file_path(self.0)
-                .map_err(|()| format_err!("can't convert path to url: {}", self.0.display()))?,
-            self.1.conv_with(line_index),
         );
         Ok(loc)
-    }
 }
 
-
 pub trait MapConvWith<'a>: Sized {
     type Ctx;
     type Output;

crates/server/src/main.rs

@@ -17,23 +17,25 @@ extern crate walkdir;
 extern crate libeditor;
 extern crate libanalysis;
 extern crate libsyntax2;
+extern crate im;
 
 mod io;
 mod caps;
 mod req;
 mod dispatch;
-mod util;
 mod conv;
 mod main_loop;
 mod vfs;
+mod path_map;
 
 use threadpool::ThreadPool;
 use crossbeam_channel::bounded;
 use flexi_logger::{Logger, Duplicate};
 use libanalysis::WorldState;
 
 use ::{
-    io::{Io, RawMsg, RawResponse, RawRequest, RawNotification}
+    path_map::PathMap,
 };
 
 pub type Result<T> = ::std::result::Result<T, ::failure::Error>;

crates/server/src/main_loop/handlers.rs

@@ -11,27 +11,29 @@ use libsyntax2::TextUnit;
 use serde_json::{to_value, from_value};
 
 use ::{
+    PathMap,
     req::{self, Decoration}, Result,
-    util::FilePath,
-    conv::{Conv, ConvWith, TryConvWith, MapConvWith},
 };
 
 pub fn handle_syntax_tree(
     world: World,
+    path_map: PathMap,
     params: req::SyntaxTreeParams,
 ) -> Result<String> {
-    let path = params.text_document.file_path()?;
-    let file = world.file_syntax(&path)?;
     Ok(libeditor::syntax_tree(&file))
 }
 
 pub fn handle_extend_selection(
     world: World,
+    path_map: PathMap,
     params: req::ExtendSelectionParams,
 ) -> Result<req::ExtendSelectionResult> {
-    let path = params.text_document.file_path()?;
-    let file = world.file_syntax(&path)?;
-    let line_index = world.file_line_index(&path)?;
     let selections = params.selections.into_iter()
         .map_conv_with(&line_index)
         .map(|r| libeditor::extend_selection(&file, r).unwrap_or(r))
@@ -42,11 +44,12 @@ pub fn handle_extend_selection(
 
 pub fn handle_document_symbol(
     world: World,
+    path_map: PathMap,
     params: req::DocumentSymbolParams,
 ) -> Result<Option<req::DocumentSymbolResponse>> {
-    let path = params.text_document.file_path()?;
-    let file = world.file_syntax(&path)?;
-    let line_index = world.file_line_index(&path)?;
 
     let mut parents: Vec<(DocumentSymbol, Option<usize>)> = Vec::new();
 
@@ -81,11 +84,12 @@ pub fn handle_document_symbol(
 
 pub fn handle_code_action(
     world: World,
+    path_map: PathMap,
     params: req::CodeActionParams,
 ) -> Result<Option<Vec<Command>>> {
-    let path = params.text_document.file_path()?;
-    let file = world.file_syntax(&path)?;
-    let line_index = world.file_line_index(&path)?;
     let offset = params.range.conv_with(&line_index).start();
     let mut ret = Vec::new();
 
@@ -105,6 +109,7 @@ pub fn handle_code_action(
 
 pub fn handle_workspace_symbol(
     world: World,
+    path_map: PathMap,
     params: req::WorkspaceSymbolParams,
 ) -> Result<Option<Vec<SymbolInformation>>> {
     let all_symbols = params.query.contains("#");
@@ -119,23 +124,26 @@ pub fn handle_workspace_symbol(
         q.limit(128);
         q
     };
-    let mut res = exec_query(&world, query)?;
     if res.is_empty() && !all_symbols {
         let mut query = Query::new(params.query);
         query.limit(128);
-        res = exec_query(&world, query)?;
     }
 
     return Ok(Some(res));
 
-    fn exec_query(world: &World, query: Query) -> Result<Vec<SymbolInformation>> {
         let mut res = Vec::new();
-        for (path, symbol) in world.world_symbols(query) {
-            let line_index = world.file_line_index(path)?;
             let info = SymbolInformation {
                 name: symbol.name.to_string(),
                 kind: symbol.kind.conv(),
-                location: (path, symbol.node_range).try_conv_with(&line_index)?,
+                    file_id, symbol.node_range,
+                    path_map, &line_index
+                )?,
                 container_name: None,
             };
             res.push(info);
@@ -146,22 +154,27 @@ pub fn handle_workspace_symbol(
 
 pub fn handle_goto_definition(
     world: World,
+    path_map: PathMap,
     params: req::TextDocumentPositionParams,
 ) -> Result<Option<req::GotoDefinitionResponse>> {
-    let path = params.text_document.file_path()?;
-    let line_index = world.file_line_index(&path)?;
     let offset = params.position.conv_with(&line_index);
     let mut res = Vec::new();
-    for (path, symbol) in world.approximately_resolve_symbol(&path, offset)? {
-        let line_index = world.file_line_index(path)?;
-        let location = (path, symbol.node_range).try_conv_with(&line_index)?;
+            file_id, symbol.node_range,
+            &path_map, &line_index,
+        )?;
         res.push(location)
     }
     Ok(Some(req::GotoDefinitionResponse::Array(res)))
 }
 
 pub fn handle_execute_command(
     world: World,
+    path_map: PathMap,
     mut params: req::ExecuteCommandParams,
 ) -> Result<req::ApplyWorkspaceEditParams> {
     if params.command.as_str() != "apply_code_action" {
@@ -172,8 +185,8 @@ pub fn handle_execute_command(
     }
     let arg = params.arguments.pop().unwrap();
     let arg: ActionRequest = from_value(arg)?;
-    let path = arg.text_document.file_path()?;
-    let file = world.file_syntax(&path)?;
     let edit = match arg.id {
         ActionId::FlipComma => libeditor::flip_comma(&file, arg.offset).map(|edit| edit()),
         ActionId::AddDerive => libeditor::add_derive(&file, arg.offset).map(|edit| edit()),
@@ -182,7 +195,7 @@ pub fn handle_execute_command(
         Some(edit) => edit,
         None => bail!("command not applicable"),
     };
-    let line_index = world.file_line_index(&path)?;
     let mut changes = HashMap::new();
     changes.insert(
         arg.text_document.uri,
@@ -231,10 +244,14 @@ impl ActionId {
     }
 }
 
-pub fn publish_diagnostics(world: World, uri: Url) -> Result<req::PublishDiagnosticsParams> {
-    let path = uri.file_path()?;
-    let file = world.file_syntax(&path)?;
-    let line_index = world.file_line_index(&path)?;
+) -> Result<req::PublishDiagnosticsParams> {
+    let file_id = uri.try_conv_with(&path_map)?;
+    let file = world.file_syntax(file_id)?;
+    let line_index = world.file_line_index(file_id)?;
     let diagnostics = libeditor::diagnostics(&file)
         .into_iter()
         .map(|d| Diagnostic {
@@ -248,10 +265,14 @@ pub fn publish_diagnostics(world: World, uri: Url) -> Result<req::PublishDiagnos
     Ok(req::PublishDiagnosticsParams { uri, diagnostics })
 }
 
-pub fn publish_decorations(world: World, uri: Url) -> Result<req::PublishDecorationsParams> {
-    let path = uri.file_path()?;
-    let file = world.file_syntax(&path)?;
-    let line_index = world.file_line_index(&path)?;
+) -> Result<req::PublishDecorationsParams> {
+    let file_id = uri.try_conv_with(&path_map)?;
+    let file = world.file_syntax(file_id)?;
+    let line_index = world.file_line_index(file_id)?;
     let decorations = libeditor::highlight(&file)
         .into_iter()
         .map(|h| Decoration {