Only remove method from end of recv, indent suggestion source

Author: tylerjw

clippy_lints/src/methods/case_sensitive_file_extension_comparisons.rs

@@ -1,4 +1,5 @@
 use clippy_utils::diagnostics::span_lint_and_then;
+use clippy_utils::source::{indent_of, reindent_multiline};
 use clippy_utils::sugg::Sugg;
 use clippy_utils::ty::is_type_lang_item;
 use if_chain::if_chain;
@@ -43,23 +44,32 @@ pub(super) fn check<'tcx>(
                         recv_str = format!("&{recv_str}");
                     }
 
-                    if recv_str.contains(".to_lowercase()") {
+                    if recv_str.ends_with(".to_lowercase()") {
                         diag.note("to_lowercase allocates memory, this can be avoided by using Path");
-                        recv_str = recv_str.replace(".to_lowercase()", "");
+                        let (prefix, _) = recv_str.split_at(recv_str.len() - ".to_lowercase()".len());
+                        recv_str = prefix.to_string();
                     }
 
-                    if recv_str.contains(".to_uppercase()") {
+                    if recv_str.ends_with(".to_uppercase()") {
                         diag.note("to_uppercase allocates memory, this can be avoided by using Path");
-                        recv_str = recv_str.replace(".to_uppercase()", "");
+                        let (prefix, _) = recv_str.split_at(recv_str.len() - ".to_uppercase()".len());
+                        recv_str = prefix.to_string();
                     }
 
+                    let suggestion_source: String = reindent_multiline(
+                        format!(
+                            "std::path::Path::new({})
+                                .extension()
+                                .map_or(false, |ext| ext.eq_ignore_ascii_case(\"{}\"))",
+                            recv_str, ext_str.strip_prefix('.').unwrap()).into(),
+                        true,
+                        Some(indent_of(cx, call_span).unwrap_or(0) + 4)
+                    ).to_string();
+
                     diag.span_suggestion(
                         recv.span.to(call_span),
                         "use std::path::Path",
-                        format!("std::path::Path::new({})
-        .extension()
-        .map_or(false, |ext| ext.eq_ignore_ascii_case(\"{}\"))", 
-                            recv_str, ext_str.strip_prefix('.').unwrap()),
+                        suggestion_source,
                         Applicability::MaybeIncorrect,
                     );
                 }