Skip to content

Commit a693cbc

Browse files
committed
changed msrv name for consistency & changed nested if for style
1 parent ca00b13 commit a693cbc

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

clippy_lints/src/methods/option_map_unwrap_or.rs

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,10 @@ pub(super) fn check<'tcx>(
7777
return;
7878
}
7979

80-
let mut suggest_is_some_and = false;
81-
// argument to `unwrap_or` is false & is_some_and is stabilised; should suggest using `is_some_and`
82-
if msrv.meets(msrvs::OPT_IS_SOME_AND) {
83-
if let ExprKind::Lit(unwrap_lit) = &unwrap_arg.kind {
84-
if let rustc_ast::LitKind::Bool(false) = unwrap_lit.node {
85-
suggest_is_some_and = true;
86-
}
87-
}
88-
}
80+
// is_some_and is stabilised && `unwrap_or` argument is false; suggest `is_some_and` instead
81+
let suggest_is_some_and = msrv.meets(msrvs::OPTION_IS_SOME_AND)
82+
&& matches!(&unwrap_arg.kind, ExprKind::Lit(lit)
83+
if matches!(lit.node, rustc_ast::LitKind::Bool(false)));
8984

9085
let mut applicability = Applicability::MachineApplicable;
9186
// get snippet for unwrap_or()

clippy_utils/src/msrvs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ macro_rules! msrv_aliases {
1919

2020
// names may refer to stabilized feature flags or library items
2121
msrv_aliases! {
22-
1,70,0 { OPT_IS_SOME_AND }
22+
1,70,0 { OPTION_IS_SOME_AND }
2323
1,68,0 { PATH_MAIN_SEPARATOR_STR }
2424
1,65,0 { LET_ELSE, POINTER_CAST_CONSTNESS }
2525
1,62,0 { BOOL_THEN_SOME, DEFAULT_ENUM_ATTRIBUTE }

0 commit comments

Comments
 (0)