dogfood

Author: lengyijun

clippy_dev/src/update_lints.rs

@@ -450,7 +450,7 @@ fn remove_lint_declaration(name: &str, path: &Path, lints: &mut Vec<Lint>) -> io
 
                 // Remove the module declaration (mod xyz;)
                 let mod_decl = format!("\nmod {name};");
-                content = content.replacen(&mod_decl, "", 1);
+                let mut content = content.replacen(&mod_decl, "", 1);
 
                 remove_impl_lint_pass(&lint.name.to_uppercase(), &mut content);
                 fs::write(path, content).unwrap_or_else(|_| panic!("failed to write to `{}`", path.to_string_lossy()));

clippy_lints/src/dereference.rs

@@ -801,11 +801,11 @@ impl TyCoercionStability {
     }
 
     fn for_mir_ty<'tcx>(tcx: TyCtxt<'tcx>, param_env: ParamEnv<'tcx>, ty: Ty<'tcx>, for_return: bool) -> Self {
-        let ty::Ref(_, mut ty, _) = *ty.kind() else {
+        let ty::Ref(_, ty, _) = *ty.kind() else {
             return Self::None;
         };
 
-        ty = tcx.try_normalize_erasing_regions(param_env, ty).unwrap_or(ty);
+        let mut ty = tcx.try_normalize_erasing_regions(param_env, ty).unwrap_or(ty);
         loop {
             break match *ty.kind() {
                 ty::Ref(_, ref_ty, _) => {

clippy_lints/src/operators/arithmetic_side_effects.rs

@@ -178,10 +178,10 @@ impl ArithmeticSideEffects {
         ) {
             return;
         };
-        let (mut actual_lhs, lhs_ref_counter) = peel_hir_expr_refs(lhs);
-        let (mut actual_rhs, rhs_ref_counter) = peel_hir_expr_refs(rhs);
-        actual_lhs = expr_or_init(cx, actual_lhs);
-        actual_rhs = expr_or_init(cx, actual_rhs);
+        let (actual_lhs, lhs_ref_counter) = peel_hir_expr_refs(lhs);
+        let (actual_rhs, rhs_ref_counter) = peel_hir_expr_refs(rhs);
+        let actual_lhs = expr_or_init(cx, actual_lhs);
+        let actual_rhs = expr_or_init(cx, actual_rhs);
         let lhs_ty = cx.typeck_results().expr_ty(actual_lhs).peel_refs();
         let rhs_ty = cx.typeck_results().expr_ty(actual_rhs).peel_refs();
         if self.has_allowed_binary(lhs_ty, rhs_ty) {

clippy_lints/src/suspicious_operation_groupings.rs

@@ -617,7 +617,7 @@ fn ident_difference_expr_with_base_location(
     }
 
     let (new_difference, new_base) = ident_difference_via_ident_iter_with_base_location(left, right, base);
-    base = new_base;
+    let base = new_base;
     difference += new_difference;
 
     (difference, base)

clippy_lints/src/unit_types/unit_arg.rs

@@ -185,7 +185,7 @@ fn fmt_stmts_and_call(
         .map(|it| it.as_ref().to_owned())
         .collect::<Vec<_>>();
     stmts_and_call.push(call_snippet_with_replacements);
-    stmts_and_call = stmts_and_call
+    let stmts_and_call: Vec<_> = stmts_and_call
         .into_iter()
         .map(|v| reindent_multiline(v.into(), true, Some(call_expr_indent)).into_owned())
         .collect();