Add lint unnecessary_option_map_or_else #14662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
llogiq
reviewed
May 12, 2025
Comment on lines
+15
to
+16
| let self_snippet = snippet(cx, recv.span, ".."); | ||
| let err_snippet = snippet(cx, def_arg.span, ".."); |
There was a problem hiding this comment.
We should use snippet_with_applicability instead here. Also the default for self_snippet should be "_", not "..".
| tmp | ||
| }, | ||
| ); | ||
| } |
There was a problem hiding this comment.
I'd like to see a test case with std::convert::identity. And one where the closure is put in a let binding before the map_or_else (we can get that with expr_or_init).
There was a problem hiding this comment.
The test case with a let binding is clear, but I am not sure if I understand correctly the test case with std::convert::identity: is it be supposed to be marked as an error? Would it be actually possible to statically check if the provided function is doing something with a parameter before returning it if said function is from an external library?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
unnecessary_option_map_or_else]: Added lint unnecessary_option_map_or_else. As suggested in the issue description, the implementation takes as reference the issue #7328. The tests for lintsoption_if_let_elseandor_fun_callneeded to be adjusted to comply with new lint.fixes #14588