Attributes beginning of defun #316
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
JFYI I'm on vacation and probably won't look at this for a few weeks at best! But thanks for the PR :) |
|
This looks reasonable enough to me. I'm not really an elisp expert by any means. I'm not sure if it'll work with more complex attributes like |
|
Removing myself as assignee =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typical scenario where this can be useful:
I want to mark a test (of a type with a bunch of derive statements) to move some code around. Calling mark-defun (C-M-h) does not select the attribute (#[test] or #[derive(...)], respectively).
This tries to fix this state of affair.
This is still WIP. I'll try to fix #299 in the same.