Skip to content

Commit 0209ac0

Browse files
Remove unnecessary TODOs
Implementing `IntoDiagnostic` can only be done with the ErrorGuaranteed.
1 parent 4e82b0a commit 0209ac0

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

compiler/rustc_const_eval/src/errors.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,6 @@ impl IntoDiagnostic<'_> for UndefinedBehaviorInfoExt<'_> {
665665
pub struct ValidationErrorInfoExt<'tcx>(ValidationErrorInfo<'tcx>);
666666

667667
impl IntoDiagnostic<'_> for ValidationErrorInfoExt<'_> {
668-
// TODO: This has to be changed to EmissionGuarantee
669668
fn into_diagnostic(self, handler: &'_ Handler) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
670669
use crate::fluent_generated::*;
671670
use crate::interpret::ValidationErrorKind::*;
@@ -1236,7 +1235,6 @@ impl ReportErrorExt for UnsupportedOpInfo {
12361235

12371236
pub struct UnsupportedExt(UnsupportedOpInfo);
12381237

1239-
// TODO: change to EmissionGuarantee
12401238
impl IntoDiagnostic<'_> for UnsupportedExt {
12411239
fn into_diagnostic(self, handler: &'_ Handler) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
12421240
use crate::fluent_generated::*;
@@ -1291,7 +1289,6 @@ impl IntoDiagnostic<'_> for UnsupportedExt {
12911289

12921290
pub struct InterpErrorExt<'a>(pub InterpError<'a>);
12931291

1294-
// TODO: EmissionGuarantee
12951292
impl IntoDiagnostic<'_> for InterpErrorExt<'_> {
12961293
fn into_diagnostic(self, handler: &'_ Handler) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
12971294
match self.0 {
@@ -1308,7 +1305,6 @@ impl IntoDiagnostic<'_> for InterpErrorExt<'_> {
13081305

13091306
pub struct MachineStopExt(Box<dyn MachineStopType>);
13101307

1311-
// TODO: EmissionGuarantee
13121308
impl IntoDiagnostic<'_> for MachineStopExt {
13131309
fn into_diagnostic(self, handler: &'_ Handler) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
13141310
let mut builder = handler.struct_diagnostic(self.0.diagnostic_message().clone());
@@ -1349,7 +1345,6 @@ impl<'tcx> ReportErrorExt for InterpError<'tcx> {
13491345

13501346
pub struct InvalidProgramInfoExt<'a>(InvalidProgramInfo<'a>);
13511347

1352-
// TODO: EmissionGuarantee
13531348
impl IntoDiagnostic<'_> for InvalidProgramInfoExt<'_> {
13541349
fn into_diagnostic(self, handler: &'_ Handler) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
13551350
use crate::fluent_generated::*;

0 commit comments

Comments
 (0)