Skip to content

Commit 022d485

Browse files
committed
mk: Make distcheck build binary tarballs on windows
These work, but aren't being built and uploaded because the bots run 'distcheck' not 'dist'.
1 parent 8b3c676 commit 022d485

File tree

1 file changed

+10
-19
lines changed

1 file changed

+10
-19
lines changed

mk/dist.mk

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -321,27 +321,20 @@ distcheck-docs: dist-docs
321321
# Primary targets (dist, distcheck)
322322
######################################################################
323323

324-
ifdef CFG_WINDOWSY_$(CFG_BUILD)
325-
326-
dist: dist-win dist-tar-bins
327-
328-
distcheck: distcheck-win
329-
$(Q)rm -Rf tmp/distcheck
330-
@echo
331-
@echo -----------------------------------------------
332-
@echo "Rust ready for distribution (see ./dist)"
333-
@echo -----------------------------------------------
334-
335-
else
324+
MAYBE_DIST_TAR_SRC=dist-tar-src
325+
MAYBE_DISTCHECK_TAR_SRC=distcheck-tar-src
336326

337327
# FIXME #13224: On OS X don't produce tarballs simply because --exclude-vcs don't work.
338328
# This is a huge hack because I just don't have time to figure out another solution.
339329
ifeq ($(CFG_OSTYPE), apple-darwin)
340330
MAYBE_DIST_TAR_SRC=
341331
MAYBE_DISTCHECK_TAR_SRC=
342-
else
343-
MAYBE_DIST_TAR_SRC=dist-tar-src
344-
MAYBE_DISTCHECK_TAR_SRC=distcheck-tar-src
332+
endif
333+
334+
# Don't bother with source tarballs on windows just because we historically haven't.
335+
ifeq ($(CFG_OSTYPE), pc-windows-gnu)
336+
MAYBE_DIST_TAR_SRC=
337+
MAYBE_DISTCHECK_TAR_SRC=
345338
endif
346339

347340
ifneq ($(CFG_DISABLE_DOCS),)
@@ -352,15 +345,13 @@ MAYBE_DIST_DOCS=dist-docs
352345
MAYBE_DISTCHECK_DOCS=distcheck-docs
353346
endif
354347

355-
dist: $(MAYBE_DIST_TAR_SRC) dist-osx dist-tar-bins $(MAYBE_DIST_DOCS)
348+
dist: $(MAYBE_DIST_TAR_SRC) dist-osx dist-win dist-tar-bins $(MAYBE_DIST_DOCS)
356349

357-
distcheck: $(MAYBE_DISTCHECK_TAR_SRC) distcheck-osx distcheck-tar-bins $(MAYBE_DISTCHECK_DOCS)
350+
distcheck: $(MAYBE_DISTCHECK_TAR_SRC) distcheck-osx distcheck-win distcheck-tar-bins $(MAYBE_DISTCHECK_DOCS)
358351
$(Q)rm -Rf tmp/distcheck
359352
@echo
360353
@echo -----------------------------------------------
361354
@echo "Rust ready for distribution (see ./dist)"
362355
@echo -----------------------------------------------
363356

364-
endif
365-
366357
.PHONY: dist distcheck

0 commit comments

Comments
 (0)