Skip to content

Commit 04ef4d1

Browse files
Mark-SimulacrumMark-Simulacrum
authored
Add triage for this week (#1733)
1 parent 7b06315 commit 04ef4d1

File tree

1 file changed

+104
-0
lines changed

1 file changed

+104
-0
lines changed

‎triage/2023-10-10.md

Lines changed: 104 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,104 @@
1+
# 2023-10-10 Triage Log
2+
3+
A quiet week, with few regressions and improvements.
4+
5+
Triage done by **@simulacrum**.
6+
Revision range: [9998f4add08c3d09c82e00975cf3a293b30160ec..84d44dd1d8ec1e98fff94272ba4f96b2a1f044ca](https://perf.rust-lang.org/?start=9998f4add08c3d09c82e00975cf3a293b30160ec&end=84d44dd1d8ec1e98fff94272ba4f96b2a1f044ca&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.8% | [0.3%, 2.9%] | 47 |
13+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.2%, 4.8%] | 19 |
14+
| Improvements ✅ <br /> (primary) | -2.0% | [-3.6%, -0.4%] | 2 |
15+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.7%, -0.4%] | 11 |
16+
| All ❌✅ (primary) | 0.7% | [-3.6%, 2.9%] | 49 |
17+
18+
19+
1 Regressions, 2 Improvements, 4 Mixed; 1 of them in rollups
20+
68 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 7 pull requests [#116492](https://github.com/rust-lang/rust/pull/116492) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=94bc9c737ea97d56f9b4076553ac37c05c1e3931&end=960754090acc9cdd2a5a57586f244c0fc712d26c&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.9% | [0.7%, 1.0%] | 2 |
29+
| Regressions ❌ <br /> (secondary) | 2.3% | [1.2%, 3.6%] | 4 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.9% | [0.7%, 1.0%] | 2 |
33+
34+
This is likely due to better ability to optimize, see
35+
[comment](https://github.com/rust-lang/rust/pull/116481#issuecomment-1755433223).
36+
37+
#### Improvements
38+
39+
Rollup of 5 pull requests [#116455](https://github.com/rust-lang/rust/pull/116455) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3bcad65fbf67b6edf87c949531fbc13435882e6b&end=cdca82c2c853c8373c0c333a2fd7d1b480d7f1d2&stat=instructions:u)
40+
41+
| (instructions:u) | mean | range | count |
42+
|:----------------------------------:|:-----:|:--------------:|:-----:|
43+
| Regressions ❌ <br /> (primary) | - | - | 0 |
44+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
45+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.9%, -0.5%] | 3 |
46+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
47+
| All ❌✅ (primary) | -0.7% | [-0.9%, -0.5%] | 3 |
48+
49+
50+
Generalize small dominators optimization [#116454](https://github.com/rust-lang/rust/pull/116454) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1e3c8f196b2753b3e463bc6be2dc446f36653279&end=4f4a413fe6931d0ad9d3ac6bd20ff36398961e64&stat=instructions:u)
51+
52+
| (instructions:u) | mean | range | count |
53+
|:----------------------------------:|:-----:|:--------------:|:-----:|
54+
| Regressions ❌ <br /> (primary) | - | - | 0 |
55+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
56+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.8%, -0.3%] | 7 |
57+
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.1%, -0.7%] | 7 |
58+
| All ❌✅ (primary) | -0.5% | [-0.8%, -0.3%] | 7 |
59+
60+
61+
#### Mixed
62+
63+
Make subtyping explicit in MIR [#115025](https://github.com/rust-lang/rust/pull/115025) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9998f4add08c3d09c82e00975cf3a293b30160ec&end=eb0f3ed59c6508a37c6598bc9762987f053993a7&stat=instructions:u)
64+
65+
| (instructions:u) | mean | range | count |
66+
|:----------------------------------:|:-----:|:--------------:|:-----:|
67+
| Regressions ❌ <br /> (primary) | 0.6% | [0.4%, 0.8%] | 2 |
68+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.1%, 1.1%] | 17 |
69+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.6%, -0.5%] | 2 |
70+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.5%, -0.5%] | 1 |
71+
| All ❌✅ (primary) | 0.0% | [-0.6%, 0.8%] | 4 |
72+
73+
74+
Remove mir::LocalDecl::internal. [#116427](https://github.com/rust-lang/rust/pull/116427) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e2939270168f2a23ef2ec0b2a193dbb63f92ae07&end=5c3a0e932b7c6864f98dac739b576e9ff5913739&stat=instructions:u)
75+
76+
| (instructions:u) | mean | range | count |
77+
|:----------------------------------:|:-----:|:--------------:|:-----:|
78+
| Regressions ❌ <br /> (primary) | 0.6% | [0.4%, 0.8%] | 4 |
79+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.1%] | 1 |
80+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
81+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
82+
| All ❌✅ (primary) | 0.4% | [-0.4%, 0.8%] | 5 |
83+
84+
85+
Remove is global hack [#116417](https://github.com/rust-lang/rust/pull/116417) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cdca82c2c853c8373c0c333a2fd7d1b480d7f1d2&end=cae0791da47bb01f16885eb233dcd66b0093a6e1&stat=instructions:u)
86+
87+
| (instructions:u) | mean | range | count |
88+
|:----------------------------------:|:-----:|:--------------:|:-----:|
89+
| Regressions ❌ <br /> (primary) | 0.4% | [0.1%, 1.4%] | 22 |
90+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
91+
| Improvements ✅ <br /> (primary) | - | - | 0 |
92+
| Improvements ✅ <br /> (secondary) | -0.7% | [-0.9%, -0.2%] | 7 |
93+
| All ❌✅ (primary) | 0.4% | [0.1%, 1.4%] | 22 |
94+
95+
96+
Always preserve DebugInfo in DeadStoreElimination. [#116183](https://github.com/rust-lang/rust/pull/116183) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ab039f79b8a0cfea01fb8aa10860560b9689e4c6&end=1e3c8f196b2753b3e463bc6be2dc446f36653279&stat=instructions:u)
97+
98+
| (instructions:u) | mean | range | count |
99+
|:----------------------------------:|:-----:|:--------------:|:-----:|
100+
| Regressions ❌ <br /> (primary) | 0.7% | [0.2%, 3.1%] | 30 |
101+
| Regressions ❌ <br /> (secondary) | 1.4% | [0.1%, 2.3%] | 13 |
102+
| Improvements ✅ <br /> (primary) | -1.1% | [-3.1%, -0.2%] | 4 |
103+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
104+
| All ❌✅ (primary) | 0.5% | [-3.1%, 3.1%] | 34 |

0 commit comments

Comments
 (0)