Skip to content

Commit 12aec07

Browse files
Simplify some uses of cfg in test cases
While adding PowerPC64 support it was noticed that some testcases should just use target_pointer_width, and others should select between x86 and !x86.
1 parent 7ff64b2 commit 12aec07

File tree

7 files changed

+9
-26
lines changed

7 files changed

+9
-26
lines changed

src/test/auxiliary/extern_calling_convention.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ pub extern "win64" fn foo(a: isize, b: isize, c: isize, d: isize) {
2424
}
2525

2626
#[inline(never)]
27-
#[cfg(any(target_arch = "x86", target_arch = "arm", target_arch = "aarch64",
28-
target_arch = "powerpc64", target_arch = "powerpc64le"))]
27+
#[cfg(not(target_arch = "x86_64"))]
2928
pub extern fn foo(a: isize, b: isize, c: isize, d: isize) {
3029
assert_eq!(a, 1);
3130
assert_eq!(b, 2);

src/test/run-pass/bitwise.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,12 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
#[cfg(any(target_arch = "x86", target_arch = "arm"))]
11+
#[cfg(any(target_pointer_width = "32"))]
1212
fn target() {
1313
assert_eq!(-1000isize as usize >> 3_usize, 536870787_usize);
1414
}
1515

16-
#[cfg(any(target_arch = "x86_64", target_arch = "aarch64",
17-
target_arch = "powerpc64", target_arch = "powerpc64le"))]
16+
#[cfg(any(target_pointer_width = "64"))]
1817
fn target() {
1918
assert_eq!(-1000isize as usize >> 3_usize, 2305843009213693827_usize);
2019
}

src/test/run-pass/intrinsic-alignment.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ mod m {
3535
}
3636

3737
#[main]
38-
#[cfg(any(target_arch = "x86_64", target_arch = "arm",
39-
target_arch = "aarch64", target_arch = "powerpc64",
40-
target_arch = "powerpc64le"))]
38+
#[cfg(not(target_arch = "x86"))]
4139
pub fn main() {
4240
unsafe {
4341
assert_eq!(::rusti::pref_align_of::<u64>(), 8);

src/test/run-pass/issue-2895.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,13 @@ impl Drop for Kitty {
2323
fn drop(&mut self) {}
2424
}
2525

26-
#[cfg(any(target_arch = "x86_64", target_arch="aarch64",
27-
target_arch="powerpc64", target_arch="powerpc64le"))]
26+
#[cfg(target_pointer_width = "64")]
2827
pub fn main() {
2928
assert_eq!(mem::size_of::<Cat>(), 8 as usize);
3029
assert_eq!(mem::size_of::<Kitty>(), 16 as usize);
3130
}
3231

33-
#[cfg(any(target_arch = "x86", target_arch = "arm"))]
32+
#[cfg(target_pointer_width = "32")]
3433
pub fn main() {
3534
assert_eq!(mem::size_of::<Cat>(), 4 as usize);
3635
assert_eq!(mem::size_of::<Kitty>(), 8 as usize);

src/test/run-pass/rec-align-u32.rs

-9
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,6 @@ struct Outer {
3535
t: Inner
3636
}
3737

38-
39-
#[cfg(any(target_arch = "x86", target_arch = "arm", target_arch = "aarch64",
40-
target_arch = "powerpc64", target_arch = "powerpc64le"))]
41-
mod m {
42-
pub fn align() -> usize { 4 }
43-
pub fn size() -> usize { 8 }
44-
}
45-
46-
#[cfg(target_arch = "x86_64")]
4738
mod m {
4839
pub fn align() -> usize { 4 }
4940
pub fn size() -> usize { 8 }

src/test/run-pass/rec-align-u64.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ mod m {
4949
pub fn size() -> usize { 12 }
5050
}
5151

52-
#[cfg(any(target_arch = "x86_64", target_arch = "arm",
53-
target_arch = "aarch64", target_arch = "powerpc64",
54-
target_arch = "powerpc64le"))]
52+
#[cfg(not(target_arch = "x86"))]
5553
pub mod m {
5654
pub fn align() -> usize { 8 }
5755
pub fn size() -> usize { 16 }

src/test/run-pass/struct-return.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ fn test1() {
4343
}
4444
}
4545

46-
#[cfg(any(target_arch = "x86_64", target_arch = "aarch64",
47-
target_arch = "powerpc64", target_arch = "powerpc64le"))]
46+
#[cfg(target_pointer_width = "64")]
4847
fn test2() {
4948
unsafe {
5049
let f = Floats { a: 1.234567890e-15_f64,
@@ -60,7 +59,7 @@ fn test2() {
6059
}
6160
}
6261

63-
#[cfg(any(target_arch = "x86", target_arch = "arm"))]
62+
#[cfg(target_pointer_width = "32")]
6463
fn test2() {
6564
}
6665

0 commit comments

Comments
 (0)