Skip to content

Commit 165f37e

Browse files
committed
rustc_mir_build: Clarify that 'mirrored' does not mean 'flipped' or 'reversed'
My intuition for 'mirrored' is that it means 'flipped' or 'reversed'. Clarify that that is not what is meant to 'mirror' the THIR from the HIR.
1 parent 1f3bf23 commit 165f37e

File tree

1 file changed

+8
-0
lines changed
  • compiler/rustc_mir_build/src/thir/cx

1 file changed

+8
-0
lines changed

compiler/rustc_mir_build/src/thir/cx/expr.rs

+8
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@ use crate::thir::cx::Cx;
2626
use crate::thir::util::UserAnnotatedTyHelpers;
2727

2828
impl<'tcx> Cx<'tcx> {
29+
/// Create a THIR expression for the given HIR expression. This expands all
30+
/// adjustments and directly adds the type information from the
31+
/// `typeck_results`. See the [dev-guide] for more details.
32+
///
33+
/// (The term "mirror" in this case does not refer to "flipped" or
34+
/// "reversed".)
35+
///
36+
/// [dev-guide]: https://rustc-dev-guide.rust-lang.org/thir.html
2937
pub(crate) fn mirror_expr(&mut self, expr: &'tcx hir::Expr<'tcx>) -> ExprId {
3038
// `mirror_expr` is recursing very deep. Make sure the stack doesn't overflow.
3139
ensure_sufficient_stack(|| self.mirror_expr_inner(expr))

0 commit comments

Comments
 (0)