address nits

Author: arielb1

src/librustc/metadata/tydecode.rs

@@ -207,8 +207,10 @@ impl<'a,'tcx> TyDecoder<'a,'tcx> {
             }
             'B' => {
                 assert_eq!(self.next(), '[');
-                // this is totally wrong, but nobody relevant cares about
-                // this field - it will die soon(TM).
+                // this is the wrong NodeId, but `param_id` is only accessed
+                // by the receiver-matching code in collect, which won't
+                // be going down this code path, and anyway I will kill it
+                // the moment wfcheck becomes the standard.
                 let node_id = self.parse_uint() as ast::NodeId;
                 assert_eq!(self.next(), '|');
                 let space = self.parse_param_space();
@@ -249,8 +251,12 @@ impl<'a,'tcx> TyDecoder<'a,'tcx> {
 
     fn parse_scope(&mut self) -> region::CodeExtent {
         self.tcx.region_maps.bogus_code_extent(match self.next() {
-            // the scopes created here are totally bogus with their
-            // NodeIDs
+            // This creates scopes with the wrong NodeId. This isn't
+            // actually a problem because scopes only exist *within*
+            // functions, and functions aren't loaded until trans which
+            // doesn't care about regions.
+            //
+            // May still be worth fixing though.
             'P' => {
                 assert_eq!(self.next(), '[');
                 let fn_id = self.parse_uint() as ast::NodeId;

src/librustc/middle/astencode.rs

@@ -1365,7 +1365,7 @@ impl<'a, 'tcx> rbml_decoder_decoder_helpers<'tcx> for reader::Decoder<'a> {
     /// the crate numbers back to the original source crate.
     ///
     /// Scopes will end up as being totally bogus. This can actually
-    /// be fixed through.
+    /// be fixed though.
     ///
     /// Unboxed closures are cloned along with the function being
     /// inlined, and all side tables use interned node IDs, so we

src/librustc/middle/infer/error_reporting.rs

@@ -201,7 +201,7 @@ impl<'tcx> ty::ctxt<'tcx> {
             // ReFree rather than dumping Debug output on the user.
             //
             // We shouldn't really be having unification failures with ReVar
-            // and ReLateBound through.
+            // and ReLateBound though.
             ty::ReSkolemized(..) | ty::ReVar(_) | ty::ReLateBound(..) => {
                 (format!("lifetime {:?}", region), None)
             }

src/librustc/middle/region.rs

@@ -177,6 +177,14 @@ impl CodeExtentData {
 }
 
 impl CodeExtent {
+    #[inline]
+    fn into_option(self) -> Option<CodeExtent> {
+        if self == ROOT_CODE_EXTENT {
+            None
+        } else {
+            Some(self)
+        }
+    }
     pub fn node_id(&self, region_maps: &RegionMaps) -> ast::NodeId {
         region_maps.code_extent_data(*self).node_id()
     }
@@ -325,7 +333,7 @@ impl RegionMaps {
                 // have (bogus) NodeId-s that overlap items created during
                 // inlining.
                 // We probably shouldn't be creating bogus code extents
-                // through.
+                // though.
                 let idx = *o.get();
                 if parent == DUMMY_CODE_EXTENT {
                     info!("CodeExtent({}) = {:?} [parent={}] BOGUS!",
@@ -413,10 +421,7 @@ impl RegionMaps {
 
     pub fn opt_encl_scope(&self, id: CodeExtent) -> Option<CodeExtent> {
         //! Returns the narrowest scope that encloses `id`, if any.
-        match self.scope_map.borrow()[id.0 as usize] {
-            ROOT_CODE_EXTENT => None,
-            c => Some(c)
-        }
+        self.scope_map.borrow()[id.0 as usize].into_option()
     }
 
     #[allow(dead_code)] // used in middle::cfg
@@ -445,32 +450,33 @@ impl RegionMaps {
             None => { }
         }
 
+        let scope_map : &[CodeExtent] = &self.scope_map.borrow();
+        let code_extents: &[CodeExtentData] = &self.code_extents.borrow();
+
         // else, locate the innermost terminating scope
         // if there's one. Static items, for instance, won't
         // have an enclosing scope, hence no scope will be
         // returned.
+        let expr_extent = self.node_extent(expr_id);
         // For some reason, the expr's scope itself is skipped here.
-        let mut id = match self.opt_encl_scope(self.node_extent(expr_id)) {
+        let mut id = match scope_map[expr_extent.0 as usize].into_option() {
             Some(i) => i,
-            None => { return None; }
+            _ => return None
         };
 
-        loop { match self.opt_encl_scope(id) {
-            Some(p) => {
-                match self.code_extent_data(p) {
-                    CodeExtentData::DestructionScope(..) => {
-                        debug!("temporary_scope({:?}) = {:?} [enclosing]",
-                               expr_id, id);
-                        return Some(id);
-                    }
-                    _ => id = p
+        while let Some(p) = scope_map[id.0 as usize].into_option() {
+            match code_extents[p.0 as usize] {
+                CodeExtentData::DestructionScope(..) => {
+                    debug!("temporary_scope({:?}) = {:?} [enclosing]",
+                           expr_id, id);
+                    return Some(id);
                 }
+                _ => id = p
             }
-            None => {
-                debug!("temporary_scope({:?}) = None", expr_id);
-                return None;
-            }
-        } }
+        }
+
+        debug!("temporary_scope({:?}) = None", expr_id);
+        return None;
     }
 
     pub fn var_region(&self, id: ast::NodeId) -> ty::Region {
@@ -591,24 +597,20 @@ impl RegionMaps {
             let mut i = 0;
             while i < 32 {
                 buf[i] = scope;
-                let superscope = scope_map[scope.0 as usize];
-                if superscope == ROOT_CODE_EXTENT {
-                    return &buf[..i+1];
-                } else {
-                    scope = superscope;
+                match scope_map[scope.0 as usize].into_option() {
+                    Some(superscope) => scope = superscope,
+                    _ => return &buf[..i+1]
                 }
                 i += 1;
             }
 
             *vec = Vec::with_capacity(64);
-            vec.extend((*buf).into_iter());
+            vec.push_all(buf);
             loop {
                 vec.push(scope);
-                let superscope = scope_map[scope.0 as usize];
-                if superscope == ROOT_CODE_EXTENT {
-                    return &*vec;
-                } else {
-                    scope = superscope;
+                match scope_map[scope.0 as usize].into_option() {
+                    Some(superscope) => scope = superscope,
+                    _ => return &*vec
                 }
             }
         }