Skip to content

Commit 221b7ca

Browse files
committed
Remove usages of Term::as_str and mark it for removal
1 parent 78bcd9b commit 221b7ca

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

src/libproc_macro/lib.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -715,6 +715,7 @@ impl Term {
715715
}
716716
}
717717

718+
// FIXME: Remove this, do not stabilize
718719
/// Get a reference to the interned string.
719720
#[unstable(feature = "proc_macro", issue = "38356")]
720721
pub fn as_str(&self) -> &str {
@@ -739,7 +740,7 @@ impl Term {
739740
#[unstable(feature = "proc_macro", issue = "38356")]
740741
impl fmt::Display for Term {
741742
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
742-
self.as_str().fmt(f)
743+
self.sym.as_str().fmt(f)
743744
}
744745
}
745746

@@ -1131,7 +1132,7 @@ impl TokenTree {
11311132
},
11321133
self::TokenTree::Term(tt) => {
11331134
let ident = ast::Ident::new(tt.sym, tt.span.0);
1134-
let sym_str = tt.sym.as_str();
1135+
let sym_str = tt.sym.to_string();
11351136
let token = if sym_str.starts_with("'") {
11361137
Lifetime(ident)
11371138
} else if sym_str.starts_with("r#") {

src/libproc_macro/quote.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ impl Quote for Op {
183183

184184
impl Quote for Term {
185185
fn quote(self) -> TokenStream {
186-
quote!(::Term::new((quote self.as_str()), (quote self.span())))
186+
quote!(::Term::new((quote self.sym.as_str()), (quote self.span())))
187187
}
188188
}
189189

src/test/compile-fail-fulldeps/proc-macro/auxiliary/attributes-included.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ fn assert_doc(slice: &mut &[TokenTree]) {
8686
}
8787

8888
match &tokens[0] {
89-
TokenTree::Term(tt) => assert_eq!("doc", tt.as_str()),
89+
TokenTree::Term(tt) => assert_eq!("doc", &*tt.to_string()),
9090
_ => panic!("expected `doc`"),
9191
}
9292
match &tokens[1] {
@@ -118,11 +118,11 @@ fn assert_invoc(slice: &mut &[TokenTree]) {
118118

119119
fn assert_foo(slice: &mut &[TokenTree]) {
120120
match &slice[0] {
121-
TokenTree::Term(tt) => assert_eq!(tt.as_str(), "fn"),
121+
TokenTree::Term(tt) => assert_eq!(&*tt.to_string(), "fn"),
122122
_ => panic!("expected fn"),
123123
}
124124
match &slice[1] {
125-
TokenTree::Term(tt) => assert_eq!(tt.as_str(), "foo"),
125+
TokenTree::Term(tt) => assert_eq!(&*tt.to_string(), "foo"),
126126
_ => panic!("expected foo"),
127127
}
128128
match &slice[2] {

src/test/run-pass-fulldeps/auxiliary/cond_plugin.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ pub fn cond(input: TokenStream) -> TokenStream {
3333
panic!("Invalid macro usage in cond: {}", cond);
3434
}
3535
let is_else = match test {
36-
TokenTree::Term(word) => word.as_str() == "else",
36+
TokenTree::Term(word) => &*word.to_string() == "else",
3737
_ => false,
3838
};
3939
conds.push(if is_else || input.peek().is_none() {

0 commit comments

Comments
 (0)