Rollup merge of #70769 - RalfJung:fixed, r=Dylan-DPC

Dylan-DPC · web-flow · commit 2448a235549c · 2020-04-05T13:13:11.000+02:00
Miri: remove an outdated FIXME We even [have a test ](https://github.com/rust-lang/rust/blob/49dc2f9f091748beb1a8a9d5b3eb3bbe7362c3bd/src/test/ui/consts/miri_unleashed/drop.rs) making sure that we detect dropping with a non-const implementation. r? @oli-obk
diff --git a/src/librustc_mir/interpret/terminator.rs b/src/librustc_mir/interpret/terminator.rs
@@ -75,7 +75,6 @@ impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
             }
 
             Drop { location, target, unwind } => {
-                // FIXME(CTFE): forbid drop in const eval
                 let place = self.eval_place(location)?;
                 let ty = place.layout.ty;
                 trace!("TerminatorKind::drop: {:?}, type {}", location, ty);

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,6 @@ impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`Drop { location, target, unwind } => {`
`78`		`- // FIXME(CTFE): forbid drop in const eval`
`79`	`78`	`let place = self.eval_place(location)?;`
`80`	`79`	`let ty = place.layout.ty;`
`81`	`80`	`trace!("TerminatorKind::drop: {:?}, type {}", location, ty);`