Skip to content

Commit 27c431c

Browse files
committed
Move codegen_naked_asm call up into MonoItem::define
1 parent 4391966 commit 27c431c

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

compiler/rustc_codegen_ssa/src/mir/mod.rs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ mod coverageinfo;
2020
pub mod debuginfo;
2121
mod intrinsic;
2222
mod locals;
23-
mod naked_asm;
23+
pub(crate) mod naked_asm;
2424
pub mod operand;
2525
pub mod place;
2626
mod rvalue;
@@ -170,11 +170,6 @@ pub fn codegen_mir<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>>(
170170
) {
171171
assert!(!instance.args.has_infer());
172172

173-
if cx.tcx().codegen_fn_attrs(instance.def_id()).flags.contains(CodegenFnAttrFlags::NAKED) {
174-
crate::mir::naked_asm::codegen_naked_asm::<Bx::CodegenCx>(cx, instance);
175-
return;
176-
}
177-
178173
let llfn = cx.get_fn(instance);
179174

180175
let mir = cx.tcx().instance_mir(instance.def);

compiler/rustc_codegen_ssa/src/mir/naked_asm.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use rustc_attr_parsing::InstructionSetAttr;
22
use rustc_middle::mir::mono::{Linkage, MonoItem, MonoItemData, Visibility};
33
use rustc_middle::mir::{InlineAsmOperand, START_BLOCK};
44
use rustc_middle::ty::layout::{LayoutOf, TyAndLayout};
5-
use rustc_middle::ty::{Instance, TyCtxt};
5+
use rustc_middle::ty::{Instance, TyCtxt, TypeVisitableExt};
66
use rustc_middle::{bug, ty};
77
use rustc_span::sym;
88

@@ -20,6 +20,7 @@ pub(crate) fn codegen_naked_asm<
2020
cx: &'a Cx,
2121
instance: Instance<'tcx>,
2222
) {
23+
assert!(!instance.args.has_infer());
2324
let mir = cx.tcx().instance_mir(instance.def);
2425

2526
let rustc_middle::mir::TerminatorKind::InlineAsm {

compiler/rustc_codegen_ssa/src/mono_item.rs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ use rustc_middle::ty::layout::{HasTyCtxt, LayoutOf};
77
use rustc_middle::{span_bug, ty};
88
use tracing::debug;
99

10+
use crate::mir::naked_asm;
1011
use crate::traits::*;
1112
use crate::{base, common};
1213

@@ -102,7 +103,16 @@ impl<'a, 'tcx: 'a> MonoItemExt<'a, 'tcx> for MonoItem<'tcx> {
102103
}
103104
}
104105
MonoItem::Fn(instance) => {
105-
base::codegen_instance::<Bx>(cx, instance);
106+
if cx
107+
.tcx()
108+
.codegen_fn_attrs(instance.def_id())
109+
.flags
110+
.contains(CodegenFnAttrFlags::NAKED)
111+
{
112+
naked_asm::codegen_naked_asm::<Bx::CodegenCx>(cx, instance);
113+
} else {
114+
base::codegen_instance::<Bx>(cx, instance);
115+
}
106116
}
107117
}
108118

0 commit comments

Comments
 (0)