Skip to content

Commit 35ba4dc

Browse files
authored
Rollup merge of #97928 - hoodmane:emscripten-no-assertions, r=tlively
Removes debug settings from wasm32_unknown_emscripten default link args This is a debug setting. We should only make debug builds if user requests a debug build. Currently this is inserted in release builds. Furthermore, it would be better to insert these settings in --pre-link-args because then it would be possible to override them if appropriate. Because these are inserted at the end, it is necessary to patch emscripten to remove them. ``@sbc100``
2 parents 0777113 + b32238a commit 35ba4dc

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

compiler/rustc_target/src/spec/wasm32_unknown_emscripten.rs

+1-9
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,7 @@ pub fn target() -> Target {
1616
let mut post_link_args = LinkArgs::new();
1717
post_link_args.insert(
1818
LinkerFlavor::Em,
19-
vec![
20-
"-s".into(),
21-
"ERROR_ON_UNDEFINED_SYMBOLS=1".into(),
22-
"-s".into(),
23-
"ASSERTIONS=1".into(),
24-
"-s".into(),
25-
"ABORTING_MALLOC=0".into(),
26-
"-Wl,--fatal-warnings".into(),
27-
],
19+
vec!["-sABORTING_MALLOC=0".into(), "-Wl,--fatal-warnings".into()],
2820
);
2921

3022
let opts = TargetOptions {

0 commit comments

Comments
 (0)