std: sys: pal: uefi: Overhaul Time

Use a time representation with 1900-01-01-00:00:00 as anchor. This is
the earliest time supported in UEFI.

Signed-off-by: Ayush Singh <[email protected]>

Author: Ayush1325

library/std/src/sys/pal/uefi/tests.rs

@@ -1,6 +1,4 @@
 use super::alloc::*;
-use super::time::*;
-use crate::time::Duration;
 
 #[test]
 fn align() {
@@ -21,21 +19,3 @@ fn align() {
         }
     }
 }
-
-#[test]
-fn epoch() {
-    let t = r_efi::system::Time {
-        year: 1970,
-        month: 1,
-        day: 1,
-        hour: 0,
-        minute: 0,
-        second: 0,
-        nanosecond: 0,
-        timezone: r_efi::efi::UNSPECIFIED_TIMEZONE,
-        daylight: 0,
-        pad1: 0,
-        pad2: 0,
-    };
-    assert_eq!(system_time_internal::uefi_time_to_duration(t), Duration::new(0, 0));
-}

library/std/src/sys/pal/uefi/time.rs

@@ -1,16 +1,73 @@
+use crate::cmp::Ordering;
 use crate::time::Duration;
 
-const SECS_IN_MINUTE: u64 = 60;
-const SECS_IN_HOUR: u64 = SECS_IN_MINUTE * 60;
-const SECS_IN_DAY: u64 = SECS_IN_HOUR * 24;
-
 #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Debug, Hash)]
 pub struct Instant(Duration);
 
-#[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Debug, Hash)]
-pub struct SystemTime(Duration);
+#[derive(Copy, Clone, Debug)]
+pub struct SystemTime {
+    // Duration from 1900-01-01-00:00:00
+    dur: Duration,
+    timezone: i16,
+    daylight: u8,
+}
+
+/// Deriving does not work because we need to account for timezone
+impl Ord for SystemTime {
+    fn cmp(&self, other: &Self) -> Ordering {
+        // Comparison between unspecified timezone and normal timezone is not allowed
+        if (self.timezone == r_efi::efi::UNSPECIFIED_TIMEZONE
+            || other.timezone == r_efi::efi::UNSPECIFIED_TIMEZONE)
+            && (self.timezone != other.timezone)
+        {
+            panic!("Cannot compare unspecified timezone with a normal timezone")
+        } else {
+            self.dur.cmp(&other.dur)
+        }
+    }
+}
+
+impl PartialOrd for SystemTime {
+    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+        Some(self.cmp(other))
+    }
+}
+
+/// Deriving does not work because we need to account for timezone
+impl PartialEq for SystemTime {
+    fn eq(&self, other: &Self) -> bool {
+        if (self.timezone == r_efi::efi::UNSPECIFIED_TIMEZONE
+            || other.timezone == r_efi::efi::UNSPECIFIED_TIMEZONE)
+            && (self.timezone != other.timezone)
+        {
+            false
+        } else {
+            self.dur.eq(&other.dur)
+        }
+    }
+}
+
+impl Eq for SystemTime {}
+
+impl crate::hash::Hash for SystemTime {
+    fn hash<H: crate::hash::Hasher>(&self, state: &mut H) {
+        self.dur.hash(state);
+    }
+}
 
-pub const UNIX_EPOCH: SystemTime = SystemTime(Duration::from_secs(0));
+pub const UNIX_EPOCH: SystemTime = SystemTime::from_uefi(r_efi::efi::Time {
+    year: 1970,
+    month: 1,
+    day: 1,
+    hour: 0,
+    minute: 0,
+    second: 0,
+    nanosecond: 0,
+    timezone: 0,
+    daylight: 0,
+    pad1: 0,
+    pad2: 0,
+});
 
 impl Instant {
     pub fn now() -> Instant {
@@ -40,21 +97,46 @@ impl Instant {
 }
 
 impl SystemTime {
+    pub(crate) const fn from_uefi(t: r_efi::efi::Time) -> Self {
+        let dur = system_time_internal::from_uefi(&t);
+        Self { dur, timezone: t.timezone, daylight: t.daylight }
+    }
+
+    pub(crate) const fn to_uefi(self) -> Option<r_efi::efi::Time> {
+        system_time_internal::to_uefi(&self.dur, self.timezone, self.daylight)
+    }
+
     pub fn now() -> SystemTime {
         system_time_internal::now()
             .unwrap_or_else(|| panic!("time not implemented on this platform"))
     }
 
     pub fn sub_time(&self, other: &SystemTime) -> Result<Duration, Duration> {
-        self.0.checked_sub(other.0).ok_or_else(|| other.0 - self.0)
+        // Comparison between unspecified timezone and normal timezone is not allowed
+        if (self.timezone == r_efi::efi::UNSPECIFIED_TIMEZONE
+            || other.timezone == r_efi::efi::UNSPECIFIED_TIMEZONE)
+            && (self.timezone != other.timezone)
+        {
+            panic!("Cannot compare unspecified timezone with a normal timezone")
+        } else {
+            self.dur.checked_sub(other.dur).ok_or_else(|| other.dur - self.dur)
+        }
     }
 
     pub fn checked_add_duration(&self, other: &Duration) -> Option<SystemTime> {
-        Some(SystemTime(self.0.checked_add(*other)?))
+        let mut temp = self.clone();
+        temp.dur = self.dur.checked_add(*other)?;
+
+        // Check if can be represented in UEFI
+        if temp.to_uefi().is_some() { Some(temp) } else { None }
     }
 
     pub fn checked_sub_duration(&self, other: &Duration) -> Option<SystemTime> {
-        Some(SystemTime(self.0.checked_sub(*other)?))
+        let mut temp = self.clone();
+        temp.dur = self.dur.checked_sub(*other)?;
+
+        // Check if can be represented in UEFI
+        if temp.to_uefi().is_some() { Some(temp) } else { None }
     }
 }
 
@@ -66,25 +148,26 @@ pub(crate) mod system_time_internal {
     use crate::mem::MaybeUninit;
     use crate::ptr::NonNull;
 
+    const SECS_IN_MINUTE: u64 = 60;
+    const SECS_IN_HOUR: u64 = SECS_IN_MINUTE * 60;
+    const SECS_IN_DAY: u64 = SECS_IN_HOUR * 24;
+
     pub fn now() -> Option<SystemTime> {
         let runtime_services: NonNull<RuntimeServices> = helpers::runtime_services()?;
         let mut t: MaybeUninit<Time> = MaybeUninit::uninit();
         let r = unsafe {
             ((*runtime_services.as_ptr()).get_time)(t.as_mut_ptr(), crate::ptr::null_mut())
         };
-
         if r.is_error() {
             return None;
         }
 
         let t = unsafe { t.assume_init() };
 
-        Some(SystemTime(uefi_time_to_duration(t)))
+        Some(SystemTime::from_uefi(t))
     }
 
-    // This algorithm is based on the one described in the post
-    // https://blog.reverberate.org/2020/05/12/optimizing-date-algorithms.html
-    pub(crate) const fn uefi_time_to_duration(t: r_efi::system::Time) -> Duration {
+    pub(crate) const fn from_uefi(t: &Time) -> Duration {
         assert!(t.month <= 12);
         assert!(t.month != 0);
 
@@ -97,7 +180,7 @@ pub(crate) mod system_time_internal {
         let y_adj: u32 = (t.year as u32) + YEAR_BASE - carry;
         let month_days: u32 = (m_adj.wrapping_add(adjust) * 62719 + 769) / 2048;
         let leap_days: u32 = y_adj / 4 - y_adj / 100 + y_adj / 400;
-        let days: u32 = y_adj * 365 + leap_days + month_days + (t.day as u32 - 1) - 2472632;
+        let days: u32 = y_adj * 365 + leap_days + month_days + (t.day as u32 - 1) - 2447065;
 
         let localtime_epoch: u64 = (days as u64) * SECS_IN_DAY
             + (t.second as u64)
@@ -112,6 +195,55 @@ pub(crate) mod system_time_internal {
 
         Duration::new(utc_epoch, t.nanosecond)
     }
+
+    pub(crate) const fn to_uefi(dur: &Duration, timezone: i16, daylight: u8) -> Option<Time> {
+        let secs: u64 = if timezone == r_efi::efi::UNSPECIFIED_TIMEZONE {
+            dur.as_secs()
+        } else {
+            // FIXME: use checked_sub_signed once stablized
+            dur.as_secs().checked_add_signed((-timezone as i64) * SECS_IN_MINUTE as i64).unwrap()
+        };
+
+        let days = secs / SECS_IN_DAY;
+        let remaining_secs = secs % SECS_IN_DAY;
+
+        let z = days + 693901;
+        let era = z / 146097;
+        let doe = z - (era * 146097);
+        let yoe = (doe - doe / 1460 + doe / 36524 - doe / 146096) / 365;
+        let mut y = yoe + era * 400;
+        let doy = doe - (365 * yoe + yoe / 4 - yoe / 100);
+        let mp = (5 * doy + 2) / 153;
+        let d = doy - (153 * mp + 2) / 5 + 1;
+        let m = if mp < 10 { mp + 3 } else { mp - 9 };
+
+        if m <= 2 {
+            y += 1;
+        }
+
+        let hour = (remaining_secs / SECS_IN_HOUR) as u8;
+        let minute = ((remaining_secs % SECS_IN_HOUR) / SECS_IN_MINUTE) as u8;
+        let second = (remaining_secs % SECS_IN_MINUTE) as u8;
+
+        // Check Bounds
+        if y >= 1900 && y <= 9999 {
+            Some(Time {
+                year: y as u16,
+                month: m as u8,
+                day: d as u8,
+                hour,
+                minute,
+                second,
+                nanosecond: dur.subsec_nanos(),
+                timezone,
+                daylight,
+                pad1: 0,
+                pad2: 0,
+            })
+        } else {
+            None
+        }
+    }
 }
 
 pub(crate) mod instant_internal {