Skip to content

Commit 3bfb4c3

Browse files
kornelskikornelski
committed
Don't recommend extern crate syntax
1 parent 4be0675 commit 3bfb4c3

19 files changed

+27
-27
lines changed

‎src/librustc_resolve/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -4091,7 +4091,7 @@ impl<'a> Resolver<'a> {
40914091
)),
40924092
)
40934093
} else if !ident.is_reserved() {
4094-
(format!("maybe a missing `extern crate {};`?", ident), None)
4094+
(format!("maybe a missing crate `{}`?", ident), None)
40954095
} else {
40964096
// the parser will already have complained about the keyword being used
40974097
return PathResult::NonModule(PartialRes::new(Res::Err));

‎src/test/ui/error-codes/E0432.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error[E0432]: unresolved import `something`
22
--> $DIR/E0432.rs:1:5
33
|
44
LL | use something::Foo;
5-
| ^^^^^^^^^ maybe a missing `extern crate something;`?
5+
| ^^^^^^^^^ maybe a missing crate `something`?
66

77
error: aborting due to previous error
88

‎src/test/ui/extern-prelude-fail.stderr

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ error[E0432]: unresolved import `extern_prelude`
22
--> $DIR/extern-prelude-fail.rs:7:9
33
|
44
LL | use extern_prelude::S;
5-
| ^^^^^^^^^^^^^^ maybe a missing `extern crate extern_prelude;`?
5+
| ^^^^^^^^^^^^^^ maybe a missing crate `extern_prelude`?
66

7-
error[E0433]: failed to resolve: maybe a missing `extern crate extern_prelude;`?
7+
error[E0433]: failed to resolve: maybe a missing crate `extern_prelude`?
88
--> $DIR/extern-prelude-fail.rs:8:15
99
|
1010
LL | let s = ::extern_prelude::S;
11-
| ^^^^^^^^^^^^^^ maybe a missing `extern crate extern_prelude;`?
11+
| ^^^^^^^^^^^^^^ maybe a missing crate `extern_prelude`?
1212

1313
error: aborting due to 2 previous errors
1414

‎src/test/ui/feature-gates/feature-gate-extern_absolute_paths.stderr

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ error[E0432]: unresolved import `core`
22
--> $DIR/feature-gate-extern_absolute_paths.rs:1:5
33
|
44
LL | use core::default;
5-
| ^^^^ maybe a missing `extern crate core;`?
5+
| ^^^^ maybe a missing crate `core`?
66

7-
error[E0433]: failed to resolve: maybe a missing `extern crate core;`?
7+
error[E0433]: failed to resolve: maybe a missing crate `core`?
88
--> $DIR/feature-gate-extern_absolute_paths.rs:4:19
99
|
1010
LL | let _: u8 = ::core::default::Default();
11-
| ^^^^ maybe a missing `extern crate core;`?
11+
| ^^^^ maybe a missing crate `core`?
1212

1313
error: aborting due to 2 previous errors
1414

‎src/test/ui/import3.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error[E0432]: unresolved import `main`
22
--> $DIR/import3.rs:2:5
33
|
44
LL | use main::bar;
5-
| ^^^^ maybe a missing `extern crate main;`?
5+
| ^^^^ maybe a missing crate `main`?
66

77
error: aborting due to previous error
88

‎src/test/ui/imports/issue-53269.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error[E0432]: unresolved import `nonexistent_module`
22
--> $DIR/issue-53269.rs:6:9
33
|
44
LL | use nonexistent_module::mac;
5-
| ^^^^^^^^^^^^^^^^^^ maybe a missing `extern crate nonexistent_module;`?
5+
| ^^^^^^^^^^^^^^^^^^ maybe a missing crate `nonexistent_module`?
66

77
error[E0659]: `mac` is ambiguous (`macro_rules` vs non-`macro_rules` from other module)
88
--> $DIR/issue-53269.rs:8:5

‎src/test/ui/imports/issue-55457.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ error[E0432]: unresolved import `non_existent`
1111
--> $DIR/issue-55457.rs:2:5
1212
|
1313
LL | use non_existent::non_existent;
14-
| ^^^^^^^^^^^^ maybe a missing `extern crate non_existent;`?
14+
| ^^^^^^^^^^^^ maybe a missing crate `non_existent`?
1515

1616
error: cannot determine resolution for the derive macro `NonExistent`
1717
--> $DIR/issue-55457.rs:5:10

‎src/test/ui/imports/unresolved-imports-used.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ error[E0432]: unresolved import `foo`
88
--> $DIR/unresolved-imports-used.rs:10:5
99
|
1010
LL | use foo::bar;
11-
| ^^^ maybe a missing `extern crate foo;`?
11+
| ^^^ maybe a missing crate `foo`?
1212

1313
error[E0603]: function `quz` is private
1414
--> $DIR/unresolved-imports-used.rs:8:10

‎src/test/ui/issues/issue-1697.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Testing that we don't fail abnormally after hitting the errors
22

33
use unresolved::*; //~ ERROR unresolved import `unresolved` [E0432]
4-
//~^ maybe a missing `extern crate unresolved;`?
4+
//~^ maybe a missing crate `unresolved`?
55

66
fn main() {}

‎src/test/ui/issues/issue-1697.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error[E0432]: unresolved import `unresolved`
22
--> $DIR/issue-1697.rs:3:5
33
|
44
LL | use unresolved::*;
5-
| ^^^^^^^^^^ maybe a missing `extern crate unresolved;`?
5+
| ^^^^^^^^^^ maybe a missing crate `unresolved`?
66

77
error: aborting due to previous error
88

‎src/test/ui/issues/issue-33464.stderr

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,19 @@ error[E0432]: unresolved import `abc`
22
--> $DIR/issue-33464.rs:3:5
33
|
44
LL | use abc::one_el;
5-
| ^^^ maybe a missing `extern crate abc;`?
5+
| ^^^ maybe a missing crate `abc`?
66

77
error[E0432]: unresolved import `abc`
88
--> $DIR/issue-33464.rs:5:5
99
|
1010
LL | use abc::{a, bbb, cccccc};
11-
| ^^^ maybe a missing `extern crate abc;`?
11+
| ^^^ maybe a missing crate `abc`?
1212

1313
error[E0432]: unresolved import `a_very_long_name`
1414
--> $DIR/issue-33464.rs:7:5
1515
|
1616
LL | use a_very_long_name::{el, el2};
17-
| ^^^^^^^^^^^^^^^^ maybe a missing `extern crate a_very_long_name;`?
17+
| ^^^^^^^^^^^^^^^^ maybe a missing crate `a_very_long_name`?
1818

1919
error: aborting due to 3 previous errors
2020

‎src/test/ui/issues/issue-36881.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error[E0432]: unresolved import `issue_36881_aux`
22
--> $DIR/issue-36881.rs:5:9
33
|
44
LL | use issue_36881_aux::Foo;
5-
| ^^^^^^^^^^^^^^^ maybe a missing `extern crate issue_36881_aux;`?
5+
| ^^^^^^^^^^^^^^^ maybe a missing crate `issue_36881_aux`?
66

77
error: aborting due to previous error
88

‎src/test/ui/issues/issue-37887.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error[E0432]: unresolved import `libc`
22
--> $DIR/issue-37887.rs:3:9
33
|
44
LL | use libc::*;
5-
| ^^^^ maybe a missing `extern crate libc;`?
5+
| ^^^^ maybe a missing crate `libc`?
66

77
error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
88
--> $DIR/issue-37887.rs:2:5

‎src/test/ui/macros/meta-item-absolute-path.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
error[E0433]: failed to resolve: maybe a missing `extern crate Absolute;`?
1+
error[E0433]: failed to resolve: maybe a missing crate `Absolute`?
22
--> $DIR/meta-item-absolute-path.rs:1:12
33
|
44
LL | #[derive(::Absolute)]
5-
| ^^^^^^^^ maybe a missing `extern crate Absolute;`?
5+
| ^^^^^^^^ maybe a missing crate `Absolute`?
66

77
error: aborting due to previous error
88

‎src/test/ui/privacy/restricted/test.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ fn main() {
4747
}
4848

4949
mod pathological {
50-
pub(in bad::path) mod m1 {} //~ ERROR failed to resolve: maybe a missing `extern crate bad;`?
50+
pub(in bad::path) mod m1 {} //~ ERROR failed to resolve: maybe a missing crate `bad`?
5151
pub(in foo) mod m2 {} //~ ERROR visibilities can only be restricted to ancestor modules
5252
}

‎src/test/ui/privacy/restricted/test.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
error[E0433]: failed to resolve: maybe a missing `extern crate bad;`?
1+
error[E0433]: failed to resolve: maybe a missing crate `bad`?
22
--> $DIR/test.rs:50:12
33
|
44
LL | pub(in bad::path) mod m1 {}
5-
| ^^^ maybe a missing `extern crate bad;`?
5+
| ^^^ maybe a missing crate `bad`?
66

77
error: visibilities can only be restricted to ancestor modules
88
--> $DIR/test.rs:51:12

‎src/test/ui/unresolved/unresolved-import.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use foo::bar; //~ ERROR unresolved import `foo` [E0432]
2-
//~^ maybe a missing `extern crate foo;`?
2+
//~^ maybe a missing crate `foo`?
33

44
use bar::Baz as x; //~ ERROR unresolved import `bar::Baz` [E0432]
55
//~| no `Baz` in `bar`

‎src/test/ui/unresolved/unresolved-import.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error[E0432]: unresolved import `foo`
22
--> $DIR/unresolved-import.rs:1:5
33
|
44
LL | use foo::bar;
5-
| ^^^ maybe a missing `extern crate foo;`?
5+
| ^^^ maybe a missing crate `foo`?
66

77
error[E0432]: unresolved import `bar::Baz`
88
--> $DIR/unresolved-import.rs:4:5

‎src/test/ui/use/use-mod/use-mod-4.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ error[E0432]: unresolved import `foo`
1414
--> $DIR/use-mod-4.rs:1:5
1515
|
1616
LL | use foo::self;
17-
| ^^^ maybe a missing `extern crate foo;`?
17+
| ^^^ maybe a missing crate `foo`?
1818

1919
error: aborting due to 3 previous errors
2020

0 commit comments

Comments
 (0)