Skip to content

Commit 452817b

Browse files
committed
auto merge of #6292 : thestinger/rust/cleanup, r=brson
2 parents 5063928 + d800147 commit 452817b

File tree

4 files changed

+93
-12
lines changed

4 files changed

+93
-12
lines changed

mk/install.mk

+4-4
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,9 @@ ifeq ($(CFG_ADB_DEVICE_STATUS),true)
192192
ifdef VERBOSE
193193
ADB = adb $(1)
194194
ADB_PUSH = adb push $(1) $(2)
195-
ADB_SHELL = adb shell $(1) $(2)
195+
ADB_SHELL = adb shell $(1) $(2)
196196
else
197-
ADB = $(Q)$(call E, adb $(1)) && adb $(1) 1>/dev/null
197+
ADB = $(Q)$(call E, adb $(1)) && adb $(1) 1>/dev/null
198198
ADB_PUSH = $(Q)$(call E, adb push $(1)) && adb push $(1) $(2) 1>/dev/null
199199
ADB_SHELL = $(Q)$(call E, adb shell $(1) $(2)) && adb shell $(1) $(2) 1>/dev/null
200200
endif
@@ -222,8 +222,8 @@ install-runtime-target: \
222222
install-runtime-target-arm-linux-androideabi-cleanup \
223223
install-runtime-target-arm-linux-androideabi-host-$(CFG_BUILD_TRIPLE)
224224
else
225-
install-runtime-target:
225+
install-runtime-target:
226226
@echo "No device to install runtime library"
227-
@echo
227+
@echo
228228
endif
229229
endif

mk/tests.mk

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ endef
9292
$(foreach target,$(CFG_TARGET_TRIPLES), \
9393
$(eval $(call DEF_TARGET_COMMANDS,$(target))))
9494

95-
# Target platform specific variables
95+
# Target platform specific variables
9696
# for arm-linux-androidabi
9797
define DEF_ADB_DEVICE_STATUS
9898
CFG_ADB_DEVICE_STATUS=$(1)
@@ -402,7 +402,7 @@ $(foreach host,$(CFG_HOST_TRIPLES), \
402402
$(eval $(call DEF_TEST_CRATE_RULES_null,$(stage),$(target),$(host),$(crate))) \
403403
), \
404404
$(eval $(call DEF_TEST_CRATE_RULES,$(stage),$(target),$(host),$(crate))) \
405-
))))))
405+
))))))
406406

407407

408408
######################################################################

src/libcore/hashmap.rs

+75-3
Original file line numberDiff line numberDiff line change
@@ -352,16 +352,27 @@ impl<K:Hash + Eq,V> Map<K, V> for HashMap<K, V> {
352352
}
353353
354354
/// Return a mutable reference to the value corresponding to the key
355+
#[cfg(stage0)]
355356
fn find_mut<'a>(&'a mut self, k: &K) -> Option<&'a mut V> {
356357
let idx = match self.bucket_for_key(k) {
357358
FoundEntry(idx) => idx,
358359
TableFull | FoundHole(_) => return None
359360
};
360-
unsafe { // FIXME(#4903)---requires flow-sensitive borrow checker
361+
unsafe {
361362
Some(::cast::transmute_mut_region(self.mut_value_for_bucket(idx)))
362363
}
363364
}
364365
366+
/// Return a mutable reference to the value corresponding to the key
367+
#[cfg(not(stage0))]
368+
fn find_mut<'a>(&'a mut self, k: &K) -> Option<&'a mut V> {
369+
let idx = match self.bucket_for_key(k) {
370+
FoundEntry(idx) => idx,
371+
TableFull | FoundHole(_) => return None
372+
};
373+
Some(self.mut_value_for_bucket(idx))
374+
}
375+
365376
/// Insert a key-value pair into the map. An existing value for a
366377
/// key is replaced by the new value. Return true if the key did
367378
/// not already exist in the map.
@@ -424,6 +435,7 @@ pub impl<K: Hash + Eq, V> HashMap<K, V> {
424435
425436
/// Return the value corresponding to the key in the map, or insert
426437
/// and return the value if it doesn't exist.
438+
#[cfg(stage0)]
427439
fn find_or_insert<'a>(&'a mut self, k: K, v: V) -> &'a V {
428440
if self.size >= self.resize_at {
429441
// n.b.: We could also do this after searching, so
@@ -447,13 +459,43 @@ pub impl<K: Hash + Eq, V> HashMap<K, V> {
447459
},
448460
};
449461
450-
unsafe { // FIXME(#4903)---requires flow-sensitive borrow checker
462+
unsafe {
451463
::cast::transmute_region(self.value_for_bucket(idx))
452464
}
453465
}
454466
467+
/// Return the value corresponding to the key in the map, or insert
468+
/// and return the value if it doesn't exist.
469+
#[cfg(not(stage0))]
470+
fn find_or_insert<'a>(&'a mut self, k: K, v: V) -> &'a V {
471+
if self.size >= self.resize_at {
472+
// n.b.: We could also do this after searching, so
473+
// that we do not resize if this call to insert is
474+
// simply going to update a key in place. My sense
475+
// though is that it's worse to have to search through
476+
// buckets to find the right spot twice than to just
477+
// resize in this corner case.
478+
self.expand();
479+
}
480+
481+
let hash = k.hash_keyed(self.k0, self.k1) as uint;
482+
let idx = match self.bucket_for_key_with_hash(hash, &k) {
483+
TableFull => fail!(~"Internal logic error"),
484+
FoundEntry(idx) => idx,
485+
FoundHole(idx) => {
486+
self.buckets[idx] = Some(Bucket{hash: hash, key: k,
487+
value: v});
488+
self.size += 1;
489+
idx
490+
},
491+
};
492+
493+
self.value_for_bucket(idx)
494+
}
495+
455496
/// Return the value corresponding to the key in the map, or create,
456497
/// insert, and return a new value if it doesn't exist.
498+
#[cfg(stage0)]
457499
fn find_or_insert_with<'a>(&'a mut self, k: K, f: &fn(&K) -> V) -> &'a V {
458500
if self.size >= self.resize_at {
459501
// n.b.: We could also do this after searching, so
@@ -478,11 +520,41 @@ pub impl<K: Hash + Eq, V> HashMap<K, V> {
478520
},
479521
};
480522
481-
unsafe { // FIXME(#4903)---requires flow-sensitive borrow checker
523+
unsafe {
482524
::cast::transmute_region(self.value_for_bucket(idx))
483525
}
484526
}
485527
528+
/// Return the value corresponding to the key in the map, or create,
529+
/// insert, and return a new value if it doesn't exist.
530+
#[cfg(not(stage0))]
531+
fn find_or_insert_with<'a>(&'a mut self, k: K, f: &fn(&K) -> V) -> &'a V {
532+
if self.size >= self.resize_at {
533+
// n.b.: We could also do this after searching, so
534+
// that we do not resize if this call to insert is
535+
// simply going to update a key in place. My sense
536+
// though is that it's worse to have to search through
537+
// buckets to find the right spot twice than to just
538+
// resize in this corner case.
539+
self.expand();
540+
}
541+
542+
let hash = k.hash_keyed(self.k0, self.k1) as uint;
543+
let idx = match self.bucket_for_key_with_hash(hash, &k) {
544+
TableFull => fail!(~"Internal logic error"),
545+
FoundEntry(idx) => idx,
546+
FoundHole(idx) => {
547+
let v = f(&k);
548+
self.buckets[idx] = Some(Bucket{hash: hash, key: k,
549+
value: v});
550+
self.size += 1;
551+
idx
552+
},
553+
};
554+
555+
self.value_for_bucket(idx)
556+
}
557+
486558
fn consume(&mut self, f: &fn(K, V)) {
487559
let mut buckets = ~[];
488560
self.buckets <-> buckets;

src/libcore/trie.rs

+12-3
Original file line numberDiff line numberDiff line change
@@ -289,9 +289,9 @@ fn chunk(n: uint, idx: uint) -> uint {
289289
(n >> sh) & MASK
290290
}
291291

292-
fn find_mut<'r, T>(child: &'r mut Child<T>, key: uint, idx: uint)
293-
-> Option<&'r mut T> {
294-
unsafe { // FIXME(#4903)---requires flow-sensitive borrow checker
292+
#[cfg(stage0)]
293+
fn find_mut<'r, T>(child: &'r mut Child<T>, key: uint, idx: uint) -> Option<&'r mut T> {
294+
unsafe {
295295
(match *child {
296296
External(_, ref value) => Some(cast::transmute_mut(value)),
297297
Internal(ref x) => find_mut(cast::transmute_mut(&x.children[chunk(key, idx)]),
@@ -301,6 +301,15 @@ fn find_mut<'r, T>(child: &'r mut Child<T>, key: uint, idx: uint)
301301
}
302302
}
303303

304+
#[cfg(not(stage0))]
305+
fn find_mut<'r, T>(child: &'r mut Child<T>, key: uint, idx: uint) -> Option<&'r mut T> {
306+
match *child {
307+
External(_, ref mut value) => Some(value),
308+
Internal(ref mut x) => find_mut(&mut x.children[chunk(key, idx)], key, idx + 1),
309+
Nothing => None
310+
}
311+
}
312+
304313
fn insert<T>(count: &mut uint, child: &mut Child<T>, key: uint, value: T,
305314
idx: uint) -> Option<T> {
306315
let mut tmp = Nothing;

0 commit comments

Comments
 (0)