Skip to content

Commit 523fea8

Browse files
committed
Auto merge of #14149 - Veykril:completion, r=Veykril
Trigger call info for more completions of signature having things
2 parents 41db8c2 + cade9f7 commit 523fea8

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

crates/ide-completion/src/render.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,7 @@ fn main() { Foo::Fo$0 }
587587
),
588588
lookup: "Foo{}",
589589
detail: "Foo { x: i32, y: i32 }",
590+
trigger_call_info: true,
590591
},
591592
]
592593
"#]],
@@ -614,6 +615,7 @@ fn main() { Foo::Fo$0 }
614615
),
615616
lookup: "Foo()",
616617
detail: "Foo(i32, i32)",
618+
trigger_call_info: true,
617619
},
618620
]
619621
"#]],
@@ -679,6 +681,7 @@ fn main() { Foo::Fo$0 }
679681
Variant,
680682
),
681683
detail: "Foo",
684+
trigger_call_info: true,
682685
},
683686
]
684687
"#]],
@@ -745,6 +748,7 @@ fn main() { let _: m::Spam = S$0 }
745748
postfix_match: None,
746749
is_definite: false,
747750
},
751+
trigger_call_info: true,
748752
},
749753
CompletionItem {
750754
label: "m::Spam::Foo",
@@ -770,6 +774,7 @@ fn main() { let _: m::Spam = S$0 }
770774
postfix_match: None,
771775
is_definite: false,
772776
},
777+
trigger_call_info: true,
773778
},
774779
]
775780
"#]],
@@ -942,6 +947,7 @@ use self::E::*;
942947
documentation: Documentation(
943948
"variant docs",
944949
),
950+
trigger_call_info: true,
945951
},
946952
CompletionItem {
947953
label: "E",

crates/ide-completion/src/render/literal.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ fn render(
113113
item.detail(rendered.detail);
114114

115115
match snippet_cap {
116-
Some(snippet_cap) => item.insert_snippet(snippet_cap, rendered.literal),
116+
Some(snippet_cap) => item.insert_snippet(snippet_cap, rendered.literal).trigger_call_info(),
117117
None => item.insert_text(rendered.literal),
118118
};
119119

crates/ide-completion/src/render/union_literal.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ pub(crate) fn render_union_literal(
7272
.set_relevance(ctx.completion_relevance());
7373

7474
match ctx.snippet_cap() {
75-
Some(snippet_cap) => item.insert_snippet(snippet_cap, literal),
75+
Some(snippet_cap) => item.insert_snippet(snippet_cap, literal).trigger_call_info(),
7676
None => item.insert_text(literal),
7777
};
7878

0 commit comments

Comments
 (0)