Skip to content

Commit 5413d2b

Browse files
committed
Add FIXME for auditing optional parameters passed to DIBuilder
1 parent 8ddd9c3 commit 5413d2b

File tree

1 file changed

+4
-0
lines changed
  • compiler/rustc_codegen_llvm/src/llvm

1 file changed

+4
-0
lines changed

compiler/rustc_codegen_llvm/src/llvm/ffi.rs

+4
Original file line numberDiff line numberDiff line change
@@ -1712,6 +1712,10 @@ unsafe extern "C" {
17121712

17131713
// FFI bindings for `DIBuilder` functions in the LLVM-C API.
17141714
// Try to keep these in the same order as in `llvm/include/llvm-c/DebugInfo.h`.
1715+
//
1716+
// FIXME(#134001): Audit all `Option` parameters, especially in lists, to check
1717+
// that they really are nullable on the C/C++ side. LLVM doesn't appear to
1718+
// actually document which ones are nullable.
17151719
unsafe extern "C" {
17161720
pub(crate) fn LLVMCreateDIBuilder<'ll>(M: &'ll Module) -> *mut DIBuilder<'ll>;
17171721
pub(crate) fn LLVMDisposeDIBuilder<'ll>(Builder: ptr::NonNull<DIBuilder<'ll>>);

0 commit comments

Comments
 (0)