Skip to content

Commit 5511e65

Browse files
committed
Hand ownership of the Definitions to map_crate.
1 parent e919f25 commit 5511e65

File tree

6 files changed

+4
-10
lines changed

6 files changed

+4
-10
lines changed

src/librustc/hir/map/mod.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ pub struct Map<'ast> {
196196
/// plain old integers.
197197
map: RefCell<Vec<MapEntry<'ast>>>,
198198

199-
definitions: &'ast RefCell<Definitions>,
199+
definitions: RefCell<Definitions>,
200200
}
201201

202202
impl<'ast> Map<'ast> {
@@ -790,7 +790,7 @@ pub fn collect_definitions<'ast>(krate: &'ast ast::Crate) -> Definitions {
790790
}
791791

792792
pub fn map_crate<'ast>(forest: &'ast mut Forest,
793-
definitions: &'ast RefCell<Definitions>)
793+
definitions: Definitions)
794794
-> Map<'ast> {
795795
let mut collector = NodeCollector::root(&forest.krate);
796796
intravisit::walk_crate(&mut collector, &forest.krate);
@@ -816,7 +816,7 @@ pub fn map_crate<'ast>(forest: &'ast mut Forest,
816816
forest: forest,
817817
dep_graph: forest.dep_graph.clone(),
818818
map: RefCell::new(map),
819-
definitions: definitions,
819+
definitions: RefCell::new(definitions),
820820
}
821821
}
822822

src/librustc_driver/driver.rs

-1
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ pub fn compile_input(sess: &Session,
165165
syntax::ext::mtwt::clear_tables();
166166
}
167167

168-
let defs = &RefCell::new(defs);
169168
let arenas = ty::CtxtArenas::new();
170169

171170
// Construct the HIR map

src/librustc_driver/test.rs

-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ use rustc_metadata::cstore::CStore;
2929
use rustc_metadata::creader::LocalCrateReader;
3030
use rustc::hir::map as hir_map;
3131
use rustc::session::{self, config};
32-
use std::cell::RefCell;
3332
use std::rc::Rc;
3433
use syntax::ast;
3534
use syntax::abi::Abi;
@@ -129,7 +128,6 @@ fn test_env<F>(source_string: &str,
129128
MakeGlobMap::No)
130129
};
131130

132-
let defs = &RefCell::new(defs);
133131
let arenas = ty::CtxtArenas::new();
134132
let ast_map = hir_map::map_crate(&mut hir_forest, defs);
135133

src/librustdoc/core.rs

-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ pub fn run_core(search_paths: SearchPaths,
162162
resolve::MakeGlobMap::No)
163163
};
164164

165-
let defs = &RefCell::new(defs);
166165
let arenas = ty::CtxtArenas::new();
167166
let hir_map = hir_map::map_crate(&mut hir_forest, defs);
168167

src/librustdoc/test.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ pub fn run(input: &str,
9595
.expect("phase_2_configure_and_expand aborted in rustdoc!");
9696
let krate = driver::assign_node_ids(&sess, krate);
9797
let dep_graph = DepGraph::new(false);
98-
let defs = &RefCell::new(hir_map::collect_definitions(&krate));
98+
let defs = hir_map::collect_definitions(&krate);
9999

100100
let mut dummy_resolver = DummyResolver;
101101
let lcx = LoweringContext::new(&sess, Some(&krate), &mut dummy_resolver);

src/test/run-make/execution-engine/test.rs

-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ extern crate rustc_metadata;
2020
extern crate rustc_resolve;
2121
#[macro_use] extern crate syntax;
2222

23-
use std::cell::RefCell;
2423
use std::ffi::{CStr, CString};
2524
use std::mem::transmute;
2625
use std::path::PathBuf;
@@ -246,7 +245,6 @@ fn compile_program(input: &str, sysroot: PathBuf)
246245
driver::lower_and_resolve(&sess, &id, &mut defs, &krate, dep_graph, MakeGlobMap::No)
247246
};
248247

249-
let defs = &RefCell::new(defs);
250248
let arenas = ty::CtxtArenas::new();
251249
let ast_map = ast_map::map_crate(&mut hir_forest, defs);
252250

0 commit comments

Comments
 (0)