Skip to content

Commit 5693ff0

Browse files
committed
Identify run-make tests by mode name instead of suite name
1 parent d8fde50 commit 5693ff0

File tree

1 file changed

+3
-5
lines changed
  • src/bootstrap/src/core/build_steps

1 file changed

+3
-5
lines changed

src/bootstrap/src/core/build_steps/test.rs

+3-5
Original file line numberDiff line numberDiff line change
@@ -1973,9 +1973,7 @@ NOTE: if you're sure you want to do this, please open an issue as to why. In the
19731973
add_link_lib_path(vec![llvm_libdir.trim().into()], &mut cmd);
19741974
}
19751975

1976-
if !builder.config.dry_run()
1977-
&& (matches!(suite, "run-make" | "run-make-fulldeps") || mode == "coverage-run")
1978-
{
1976+
if !builder.config.dry_run() && matches!(mode, "run-make" | "coverage-run") {
19791977
// The llvm/bin directory contains many useful cross-platform
19801978
// tools. Pass the path to run-make tests so they can use them.
19811979
// (The coverage-run tests also need these tools to process
@@ -1987,7 +1985,7 @@ NOTE: if you're sure you want to do this, please open an issue as to why. In the
19871985
cmd.arg("--llvm-bin-dir").arg(llvm_bin_path);
19881986
}
19891987

1990-
if !builder.config.dry_run() && matches!(suite, "run-make" | "run-make-fulldeps") {
1988+
if !builder.config.dry_run() && mode == "run-make" {
19911989
// If LLD is available, add it to the PATH
19921990
if builder.config.lld_enabled {
19931991
let lld_install_root =
@@ -2007,7 +2005,7 @@ NOTE: if you're sure you want to do this, please open an issue as to why. In the
20072005

20082006
// Only pass correct values for these flags for the `run-make` suite as it
20092007
// requires that a C++ compiler was configured which isn't always the case.
2010-
if !builder.config.dry_run() && matches!(suite, "run-make" | "run-make-fulldeps") {
2008+
if !builder.config.dry_run() && mode == "run-make" {
20112009
cmd.arg("--cc")
20122010
.arg(builder.cc(target))
20132011
.arg("--cxx")

0 commit comments

Comments
 (0)