Skip to content

Commit 57717eb

Browse files
committed
Don't use new-llvm-pass-manager=no in test
1 parent e2661ba commit 57717eb

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/test/codegen/panic-in-drop-abort.rs

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
// compile-flags: -Z panic-in-drop=abort -O -Z new-llvm-pass-manager=no
1+
// compile-flags: -Z panic-in-drop=abort -O
2+
// ignore-msvc
23

34
// Ensure that unwinding code paths are eliminated from the output after
45
// optimization.
56

6-
// This test uses -Z new-llvm-pass-manager=no, because the expected optimization does not happen
7-
// on targets using SEH exceptions (i.e. MSVC) anymore. The core issue is that Rust promises that
7+
// This test uses ignore-msvc, because the expected optimization does not happen on targets using
8+
// SEH exceptions with the new LLVM pass manager anymore, see
9+
// https://github.com/llvm/llvm-project/issues/51311. The core issue is that Rust promises that
810
// the drop_in_place() function can't unwind, but implements it in a way that *can*, because we
911
// currently go out of our way to allow longjmps, which also use the unwinding mechanism on MSVC
1012
// targets. We should either forbid longjmps, or not assume nounwind, making this optimization

0 commit comments

Comments
 (0)